Feature - Allow serialize Enum object #2457
Conversation
trgiangdo
changed the title
| if len(val) == 1 and list(val.keys())[0] in cls._registered_types.keys(): | ||
| return cls._registered_types[list(val.keys())[0]]._pythonify(list(val.values())[0]) |
There was a problem hiding this comment.
This if command handles the case where a dataclass instance is serialized into a dictionary.
For example, UserAttribute("email", "credential_mail", default="[email protected]") will be serialized to
{ "USER_ATTRIBUTE": {"name": "email", "credentials_name": "credentials_mail", "default": "[email protected]"}
The key is used to identify the type of the serialized object.
|
LGTM 😃 |
| elif dynamic_type == "enum": | ||
| return _TemplateHandler._to_enum(actual_val) |
There was a problem hiding this comment.
Just to be sure I understand: This case does not cover internal enums (SCOPE and FREQUENCY), as they are caught up by:
if dynamic_type in cls._registered_types.keys():
return cls._registered_types[dynamic_type]._pythonify(actual_val)
which transforms the string SCENARIO:SCOPE into a Scope instance with the SCENARIO value.
Your case transforms the string Gender.male:enum into the Gender enum with the male value.
Am I correct?
There was a problem hiding this comment.
yes, all registered types are handled first, then the enum
What type of PR is this? (check all applicable)
Description
This PR allows the _BaseSerializer to serialize and deserialize an Enum object.