Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow front-end synchronization #2452

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

FredLL-Avaiga
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

In case of server shutdown and restart, the front-end can detect that it is not talking to the same server instance.
controlled by config.app_id = True

Related Tickets & Documents

How to reproduce the issue

  • Use any app
  • stop the server
  • restart the server
  • try to update a variable

In case of server shutdown and restart, the front-end can detect that it is not talking to the same server instance.
commanded by config.app_id = True
resolves #2344
@FredLL-Avaiga FredLL-Avaiga added 🟥 Priority: Critical Must be addressed as soon as possible 📈 Improvement Improvement of a feature. 🖰 GUI Related to GUI 📝Release Notes Impacts the Release Notes or the Documentation in general labels Feb 18, 2025
@FredLL-Avaiga FredLL-Avaiga self-assigned this Feb 18, 2025
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Coverage report for ./frontend/taipy

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected >=80%, but got 51.87376725838264%

St.
Category Percentage Covered / Total
🔴 Statements 51.87% 263/507
🔴 Branches 21.61% 67/310
🔴 Functions 14.66% 17/116
🔴 Lines 53.19% 242/455

Test suite run success

7 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from a25139b

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@FredLL-Avaiga
Copy link
Member Author

Nice

Are you happy with the config app_id boolean default false ?

Copy link
Member

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FredLL-Avaiga FredLL-Avaiga merged commit bf929ea into develop Feb 19, 2025
133 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the feature/#2344-allow-front-end-synchronization branch February 19, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖰 GUI Related to GUI 📈 Improvement Improvement of a feature. 🟥 Priority: Critical Must be addressed as soon as possible 📝Release Notes Impacts the Release Notes or the Documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 BUG] De-synchronized front-ends and back-end
3 participants