Subscribers: Add notice of how many subscribers were added, skipped, failed. #98562

allilevine · 2025-01-17T22:20:31Z

Related to #97994

Proposed Changes

Show a more detailed notice when a subscriber import completes. I also looked into showing an error message in the form, but we don't have this data until the import completes. Rather than keep the form open for however long it takes, or ask the user not to navigate away, this notice shows when the data is ready.

Before:

After:

Why are these changes being made?

To show the user how many of their subscribers were imported, already existed, or failed.

Testing Instructions

Go to /subscribers/{site URL}
Import a mix of new and existing addresses, and check that the notice reflects the import correctly.
Test both manual and CSV importing.
Check that you can dismiss the notice.

Note that if you import with categories, you'll get 0 already subscribed because we re-import with the correct categories.

Pre-merge Checklist

Has the general commit checklist been followed? (PCYsg-hS-p2)
Have you written new tests for your changes?
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
Have you checked for TypeScript, React or other console errors?
Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
- For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions · 2025-01-17T22:20:45Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-131673

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-131673&env=jetpack

Automattic for Agencies live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-131673&env=a8c-for-agencies

matticbot · 2025-01-17T22:30:08Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~490 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
subscribers       +697 B  (+0.1%)     +394 B  (+0.1%)
people            +255 B  (+0.0%)      +67 B  (+0.0%)
import             +95 B  (+0.0%)      +29 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1507 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-calypso-my-sites-stats-pages-subscribers      +5652 B  (+3.9%)    +1507 B  (+3.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

matticbot · 2025-01-17T22:31:16Z

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

notifications
odyssey-stats
wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/real-time-subscriber-import-results on your sandbox.

allilevine · 2025-01-21T16:59:02Z

client/my-sites/subscribers/components/subscribers-page/subscribers-page-context.tsx

@@ -90,6 +91,7 @@ export const SubscribersPageProvider = ( {
 	const [ showMigrateSubscribersModal, setShowMigrateSubscribersModal ] = useState( false );
 	const [ debouncedSearchTerm ] = useDebounce( searchTerm, 300 );
 	const { hasManySubscribers } = useManySubsSite( siteId );
+	const { completedJob } = useActiveJobRecognition( siteId ?? 0 );


I've added completedJob to return the data we get from the import endpoint response.

allilevine · 2025-01-21T17:00:00Z

client/my-sites/subscribers/components/subscribers-page/subscribers-page-context.tsx

+			const { email_count, subscribed_count, already_subscribed_count, failed_subscribed_count } =
+				completedJob;
+			dispatch(
+				successNotice(


This message shows until dismissed.

holdercp

Code makes sense to me, and works as advertised:

holdercp · 2025-01-29T02:44:41Z

client/my-sites/subscribers/components/subscribers-page/subscribers-page-context.tsx

+			dispatch(
+				successNotice(
+					translate(
+						'Import completed. %(added)d subscribed, %(skipped)d already subscribed, and %(failed)d failed out of %(total)d %(totalLabel)s.',


I didn't know you could interpolate values in translate like this! TIL.

Yes! There's more info here: https://github.com/Automattic/wp-calypso/blob/trunk/packages/i18n-calypso/README.md#string-substitution

Which reminds me that I should request translation. 😅

a8ci18n · 2025-01-29T15:22:06Z

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17218194

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @allilevine for including a screenshot in the description! This is really helpful for our translators.

a8ci18n · 2025-02-04T12:30:25Z

Translation for this Pull Request has now been finished.

allilevine self-assigned this Jan 17, 2025

allilevine force-pushed the add/real-time-subscriber-import-results branch 2 times, most recently from aa6a23c to 8f41011 Compare January 21, 2025 16:54

allilevine commented Jan 21, 2025

View reviewed changes

allilevine marked this pull request as ready for review January 21, 2025 18:16

allilevine requested a review from arcangelini January 21, 2025 22:06

matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 21, 2025

allilevine force-pushed the add/real-time-subscriber-import-results branch from 29e312a to 47400da Compare January 23, 2025 14:39

allilevine requested a review from a team January 23, 2025 16:48

allilevine force-pushed the add/real-time-subscriber-import-results branch from 47400da to cffb3e7 Compare January 28, 2025 19:57

holdercp approved these changes Jan 29, 2025

View reviewed changes

allilevine added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jan 29, 2025

allilevine added 3 commits January 31, 2025 09:47

Add notice of how many subscribers were added, skipped, failed.

5a379ff

Minimize changes and edit import job notice.

9583d4e

Revert changes to add-form component.

0af970e

allilevine force-pushed the add/real-time-subscriber-import-results branch from cffb3e7 to 0af970e Compare January 31, 2025 14:47

allilevine mentioned this pull request Jan 31, 2025

Newsletter imports: Handle errors correctly #99162

Merged

8 tasks

allilevine merged commit 86e0e15 into trunk Jan 31, 2025
13 checks passed

allilevine deleted the add/real-time-subscriber-import-results branch January 31, 2025 16:29

github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Jan 31, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subscribers: Add notice of how many subscribers were added, skipped, failed. #98562

Subscribers: Add notice of how many subscribers were added, skipped, failed. #98562

allilevine commented Jan 17, 2025 •

edited

Loading

github-actions bot commented Jan 17, 2025 •

edited by matticbot

Loading

matticbot commented Jan 17, 2025 •

edited

Loading

matticbot commented Jan 17, 2025 •

edited

Loading

allilevine Jan 21, 2025

allilevine Jan 21, 2025

holdercp left a comment

holdercp Jan 29, 2025

allilevine Jan 29, 2025

a8ci18n commented Jan 29, 2025

a8ci18n commented Feb 4, 2025

Subscribers: Add notice of how many subscribers were added, skipped, failed. #98562

Subscribers: Add notice of how many subscribers were added, skipped, failed. #98562

Conversation

allilevine commented Jan 17, 2025 • edited Loading

Proposed Changes

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

github-actions bot commented Jan 17, 2025 • edited by matticbot Loading

matticbot commented Jan 17, 2025 • edited Loading

matticbot commented Jan 17, 2025 • edited Loading

allilevine Jan 21, 2025

Choose a reason for hiding this comment

allilevine Jan 21, 2025

Choose a reason for hiding this comment

holdercp left a comment

Choose a reason for hiding this comment

holdercp Jan 29, 2025

Choose a reason for hiding this comment

allilevine Jan 29, 2025

Choose a reason for hiding this comment

a8ci18n commented Jan 29, 2025

a8ci18n commented Feb 4, 2025

allilevine commented Jan 17, 2025 •

edited

Loading

github-actions bot commented Jan 17, 2025 •

edited by matticbot

Loading

matticbot commented Jan 17, 2025 •

edited

Loading

matticbot commented Jan 17, 2025 •

edited

Loading