Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Show more informative message when trying to transfer an unsupported premium domain #92190

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

leonardost
Copy link
Contributor

@leonardost leonardost commented Jun 27, 2024

Proposed Changes

This PR show a more informative message when trying to transfer a premium domain for a TLD that we don't support premiums yet, e.g. .biz.

This PR depends on D153680-code.

Screenshots

Before After
Screenshot 2024-06-27 at 16 03 42 Screenshot 2024-06-27 at 16 03 27

Why are these changes being made?

As reported in p1709819940847739-slack-C0761SX4K, this is confusing for users that try to transfer premium domains to us and we support the domain's TLD, we just don't support premiums for that TLD.

Testing Instructions

  • Sandbox the public API
  • Apply D153680-code to your sandbox
  • Go to /setup/domain-transfer/
  • Test inputting brainy.biz and any auth code
  • Ensure the new error message is shown

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@leonardost leonardost requested a review from a team as a code owner June 27, 2024 19:18
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 27, 2024
@leonardost leonardost self-assigned this Jun 27, 2024
@matticbot
Copy link
Contributor

matticbot commented Jun 27, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~76 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
videopress-flow            +369 B  (+0.0%)      +76 B  (+0.0%)
update-design-flow         +369 B  (+0.0%)      +76 B  (+0.0%)
sensei-flow                +369 B  (+0.1%)      +76 B  (+0.0%)
link-in-bio-tld-flow       +369 B  (+0.0%)      +76 B  (+0.0%)
domains                    +369 B  (+0.0%)      +76 B  (+0.0%)
copy-site-flow             +369 B  (+0.1%)      +76 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~76 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
async-load-signup-steps-domains       +369 B  (+0.1%)      +76 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/show-better-message-when-a-domain-cannot-be-transferred-due-to-it-being-premim on your sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants