Fix back button on domains step when coming from playground #108656
Merged
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
the
[Status] Needs Review
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
zaerl
approved these changes
Feb 12, 2026
| case 'playground': | ||
| return navigate( 'domains' ); | ||
| case 'playground': { | ||
| const backTo = window.location.pathname + window.location.search; |
Contributor
There was a problem hiding this comment.
I checked the code, and unfortunately, the domains step has a custom back button that doesn't rely on automatic history. So this is the best approach.
The only change I suggest is to use React useLocation() hook, which is mockable in tests. Feel free to use it or land this PR as is.
Great work, as always 🙂
Member
Author
There was a problem hiding this comment.
I tried and it breaks. Pls see my revert commit's message. Going to merge as is.
ashfame
force-pushed
the
fix_back_link_pg_flow
branch
2 times, most recently
from
2fe2a4d to
bb4e51d
Compare
When navigating from the playground step to the domains step in the onboarding flow, the back button incorrectly showed "Back to sites" instead of allowing the user to return to the playground. The original playground commit (999290b) fixed this in the legacy domains step, but the fix was lost during the Domain Search Rewrite (f219972). The rewritten step uses a `back_to` query parameter to control the back button, but the playground-to-domains navigation never set it. Pass the current playground URL as `back_to` when navigating to the domains step so the existing back button logic picks it up correctly.
…testing" This reverts commit df46a61. useLocation() from react-router returns paths relative to the router basename ("setup"), so it gives /onboarding/playground instead of /setup/onboarding/playground. Since back_to is used as an href on <Step.BackButton>, it needs the full browser path. Hence, reverted to window.location which provides the correct absolute path.
ashfame
force-pushed
the
fix_back_link_pg_flow
branch
from
bb4e51d to
ef551a0
Compare
github-actions
bot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When navigating from the playground step to the domains step in the onboarding flow, the back button incorrectly showed "Back to sites" instead of allowing the user to return to the playground.
The original playground commit (999290b) fixed this in the legacy domains step, but the fix was lost during the Domain Search Rewrite (f219972). The rewritten step uses a
back_toquery parameter to control the back button, but the playground-to-domains navigation never set it.Pass the current playground URL as
back_towhen navigating to the domains step so the existing back button logic picks it up correctly.Fixes https://linear.app/a8c/issue/ARC-1458/back-button-from-domains-step-links-to-mywordpresscomsites
Proposed Changes
Why are these changes being made?
Testing Instructions
Pre-merge Checklist