Skip to content

Improve ergonomics for Kotlin wrapper #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2025
Merged

Improve ergonomics for Kotlin wrapper #744

merged 4 commits into from
May 27, 2025

Conversation

oguzkocer
Copy link
Contributor

@oguzkocer oguzkocer commented May 23, 2025

Improves a few things in the Kotlin wrapper:

  • Renames WpRequestResult.WpRequestSuccess to WpRequestResult.Success
  • Renames WpRequestResult.WpRequestSuccess.data to WpRequestResult.WpRequestSuccess.response because the previous data field has another data field inside, so in usage, it looked like success.data.data.
  • Adds a few Kotlin extensions for ParsedUrl and in most of the API it replaces it with java.net.URL and internally converts it to ParsedUrl. I'll take a look to see if we could just lift ParsedUrl as URL in another PR.
  • Publishes Kotlin source files so it's easier to work with from the clients.

@oguzkocer oguzkocer added this to the 0.2 milestone May 23, 2025
@oguzkocer oguzkocer marked this pull request as ready for review May 24, 2025 02:53
@oguzkocer oguzkocer enabled auto-merge (squash) May 24, 2025 02:53
@oguzkocer oguzkocer requested a review from a team May 24, 2025 02:58
@oguzkocer oguzkocer merged commit b1a6e1d into trunk May 27, 2025
20 checks passed
@oguzkocer oguzkocer deleted the kotlin-ergonomics branch May 27, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants