Update get_csv implementation to support URL encoded by WordPress core #1136
+175
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
requested changes
Feb 2, 2026
wp_api/src/url_query.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| fn test_get_csv_with_php_array_stops_at_gap() { |
Contributor
There was a problem hiding this comment.
I don't think it should work this way – PHP makes it really easy to end up with a valid state that looks like this (by using array_unique for instance). If the server sends back status[0]=draft&status[4]=publish&status[4234]=pending, we know what it means, and I think we should handle it properly?
jkmassel
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to wordpress-mobile/GutenbergKit#299 (comment).
wp/v2/posts?status=anyresponse's "next link" is not parsed correctly at the moment. The "next link" contains "status[0]=any", whereas the library (theget_csvfunction specifically) looks for thestatuskey. This results in thestatusquery being lost.I have added an integration test to this PR, and Claude Code added some unit test to verify the fix.