Skip to content

Migration: Re-use async batch infrastructure #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from

Conversation

obenland
Copy link
Member

One thing I noticed while testing these changes is that we'll end up with a lot of activitypub_async_batch events that kind of obscure what they do until you look at the args for the individual jobs. Not sure how we feel about that.
Maybe we should just keep it to batches and not move the async_migration job?

Proposed changes:

  • Updates migration jobs to re-using the Scheduler::async_batch infrastructure
  • Update tests to account for the above changes.

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Go to '..'

@obenland obenland requested a review from a team February 19, 2025 17:42
@obenland obenland self-assigned this Feb 19, 2025
@pfefferle
Copy link
Member

@obenland what about this PR?

@obenland
Copy link
Member Author

Depends on #1521.

@obenland obenland marked this pull request as ready for review May 13, 2025 18:30
@obenland obenland added Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary. and removed [Status] In Progress labels May 13, 2025
@obenland
Copy link
Member Author

@pfefferle This should be ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants