Decouple './client/multi-currency-setup' #9348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sharing occurs between WooPayments v1 and MCCY v2.
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +5.98 kB (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
As opposed to being imported from 'multi-currency/data'. So, we mock 'wcpay/data' in order to prevent the other store hooks/data from initializing.
6 tasks
lovo-h
changed the title
lovo-h
requested review from
a team and
asumaran
and removed request for
a team
Base automatically changed from
migrate/data-multi-currency
to
multi-currency-v2
August 29, 2024 17:21
ricardo
reviewed
Aug 30, 2024
| CollapsibleBody, | ||
| Search, | ||
| LoadableBlock, | ||
| } from 'multi-currency/interface/components'; | ||
| import WizardTaskItem from '../../wizard/task-item'; |
There was a problem hiding this comment.
Question: It seems like we have a pretty similar WizardTaskItem from interface/components. I wonder if we should use only one? And adapt V1 to have a visibleDescription prop.
There was a problem hiding this comment.
Good call out. De-duplicated in 1424558.
@ricardo: Actually, at this point, we can go ahead and test the multi-currency setup wizard:
By running these tests, I ran into an issue where the currencies were not displaying. This was fixed in 4996381. |
ricardo
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 108-gh-Automattic/woopayments.
Changes proposed in this Pull Request
The changes in this PR continue the MCCY migration process to V2. More specifically, the MCCY setup is migrated to V2. However, this is an intermediary change that will depend on the changes from the following issues to be completed before it is fully functional:
Testing instructions
Confirm Full Migration of `./client/multi-currency-setup
npm run test:jscommand and ensure all tests pass../client/multi-currency-setupwere moved to./multi-currency/setup, properly disconnected from WooPayments, properly reconnected into MCCY, and interfaced with WooPayments through the interface later (e.g../multi-currency/interface/*). Note: there exist some dependencies to some UI components in./client/multi-currencythat will need to be migrated. However, this cannot happen until after 107-gh-Automattic/woopayments has been merged.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge