add: test instructions icon animation #9290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +486 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
frosso
force-pushed
the
update/test-instructions-icon-animation
branch
from
b6359fe
to
9a19c9d
Compare
frosso
commented
Aug 21, 2024
| @@ -39,6 +39,6 @@ public function __construct( $token_service ) { | |||
| * @return string | |||
| */ | |||
| public function get_testing_instructions() { | |||
| return __( '<strong>Test mode:</strong> use the test account number <number>000123456</number><button></button>. Other payment methods may redirect to a Stripe test page to authorize payment. More test card numbers are listed <a>here</a>.', 'woocommerce-payments' ); | |||
There was a problem hiding this comment.
I needed to change the markup being generated.
Before: button and test number were two separate elements.
Now: button wraps the test number, to make the click target bigger.
frosso
commented
Aug 21, 2024
frosso
force-pushed
the
update/test-instructions-icon-animation
branch
from
0058e29
to
0e9c6ea
Compare
frosso
commented
Sep 3, 2024
| @@ -9,25 +9,46 @@ | |||
| border: none !important; | |||
| // some themes might override the color on all `button`s - whose selector has higher specificity and our class selector. | |||
| background-color: transparent !important; | |||
| padding: 3px; | |||
| font-weight: normal; | |||
There was a problem hiding this comment.
Since the markup changed, the styles needed to change as well.
Before, the button element didn't have any text, so we didn't really care what it looked like.
Now, we need to ensure the text within the button element plays nice across different themes and browsers.
So I reset the padding, changed the font-size and font-weight, ensured the cursor was set to pointer (I dunno why, but it wasn't before by default), and text color and background color matched the surrounding text.
I tested this across different themes, but I'm only somewhat concerned about compatibility.
This is only applied when the plugin is in test mode, so in production the whole instructions set is not going to be visible.
frosso
requested review from
a team and
mdmoore
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9399
Changes proposed in this Pull Request
Adding a little animation on hover, click, success of the clickable payment method icon - as discussed here: pfHfG4-gT-p2#comment-238
I needed to change the markup being generated:
Demo on blocks and cart checkout:
Also tested on a bunch of other theme variations (TT4, Storefront, TT3, TT2 - blocks & shortcode checkout):
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge