add default (= null) for classNames prop so it's optional for WizardTaskItem and CollapsibleBody
#9157
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- for WizardTaskItem and CollapsibleBody
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +116 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
added 2 commits
July 25, 2024 08:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9142
Changes proposed in this Pull Request
classNamesinWizardTaskItemandCollapsibleBody.classNamestruly optional.Clients currently have to pass
classNames = { null }to appease TypeScript. The prop is actually optional, only used if client wants to customise theclassof generated markup.See https://github.com/Automattic/woocommerce-payments/blob/develop/client/vat/form/tasks/vat-number-task.tsx for an example.
The goal of this PR is to streamline code like
VatNumberTaskso it doesn't need to pass meaninglessclassName={ null }.Testing instructions
WizardTaskItemandCollapsibleBody, e.g. show the VAT modal. See appendix for VAT info modal testing instructions.WizardTaskItemandCollapsibleBody…classNames={ null }, ensure no errors/linter/typescript warnings and UI works as expected.classNamesand ensure they are rendered correctly in generated markup.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge