Prevent WooPayments-specific styles in the Checkout block to leak to other payment methods #11085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… other payment methods
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +35 B (0%) Total Size: 873 kB
ℹ️ View Unchanged
|
|
Thanks for the review, @rtio! It's my first time merging a PR in WooPayments, am I right to assume that these changes will be included in WooPayments 10.1? In which case, I should add the testing instructions here, right? And is there something that needs to be done on #11081? (Sorry if that's documented somewhere and I missed it, but I couldn't find what needs to be done besides the merge. 😅 Thanks in advance!) |
|
@Aljullu - it will be on 10.2.0 PaJDYF-1gY-p2 If this is urgent, we can consider it. May ask here p1760002069118999-slack-CGGCLBN58 |
No, no worries. It was just to know if I need to do something besides merging. |
As @htdat stated, this is expected to be released on 10.2. Thanks for asking. |
|
Thanks folks! I just merged the PR, I see in the PR template there is a |
|
Unless it changes an existing flow, you should be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
WooPayments styles are leaking into other payment methods in the Checkout block. I could notice a conflict with WooCommerce PayPal Payments, but other payment methods might be affected as well. This PR makes the CSS selectors match only the WooPayments method. It doesn't affect the specificity by using a
:where()selector.This PR has no tests because it's CSS-only.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge