Draft PR: retain current UX but use server based export for both download on browser and email export #10049
+28
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server export instead of using CSV export.
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -31 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
jessy-p
changed the title
|
I did a manual test on the transactions page with less than 25 transactions filtered.
|
6 tasks
Jinksi
reviewed
Jan 3, 2025
There was a problem hiding this comment.
🌟 Very nice @jessy-p! I prefer this approach to removing client-side download completely.
We can implement server-side logic to significantly increase the client-side download row-count limit higher than 25-100 (10,000? 1,000,000?). We can test server performance to find where this limit should be → when async export is required.
I think this would offer a better UX for most flows, with the existing email-based flow remaining in place for very large and slow exports.
Comment on lines
+694
to
+696
| const link = document.createElement( 'a' ); | ||
| link.href = response.download_url; | ||
| link.click(); |
There was a problem hiding this comment.
💭 Note, this could be a window.location.href, but maybe there's a benefit to link.click() that I'm not thinking about?
Suggested change
| const link = document.createElement( 'a' ); | |
| link.href = response.download_url; | |
| link.click(); | |
| window.location.href = response.download_url; |
There was a problem hiding this comment.
Won't window.location.href load the current file in that tab? I was trying to get the same behaviour that we have now with saveFile which is to download the file in background.
Definitely! But I think we can focus on matching it with pagesize (25-100) currently, so that it adheres to the existing and Core UX principles, which seems to be:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative approach for #9969
Changes proposed in this Pull Request
In this PR, the UX for browser download remains the same, but the backend implementation is changed so that the server export is used for generating the CSV which is made available immediately. This approach does NOT change the UX for merchant (i.e. download is available immediately for single page export), but it solves the overhead and issues of maintaining multiple implementations that do not match.
The corresponding server changes are on https://github.com/Automattic/transact-platform-server/pull/7077
NOTE:
This is a draft PR and needs to refined to make the final solution.
Testing instructions
Apply changes from Server PR https://github.com/Automattic/transact-platform-server/pull/7077 along with this branch
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge