Fix ECE exception when payment fails #10048
Open
+14
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarcosta99
requested review from
a team and
asumaran
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -66 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
asumaran
requested changes
Jan 2, 2025
There was a problem hiding this comment.
LGTM! Tests as expected. JS error is gone. Just left a minor comment for you @cesarcosta99
| */ | ||
| abortPayment: ( payment, message ) => { | ||
| payment.paymentFailed( { reason: 'fail' } ); | ||
| abortPayment: async ( message ) => { |
There was a problem hiding this comment.
Why was the async keyword added here? I don’t see any asynchronous operations being performed inside this method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9990.
Changes proposed in this Pull Request
This PR removes the
payment.paymentFailedcall when aborting the ECE payment. I went with this approach because it looks like we're mistakenly calling that function.The error message ("Ensure you are either submitting a payment or calling paymentFailed() once per confirm event") indicates an integration error. I confirmed we're calling that function just once, and I've simulated errors before and after confirming the intent, and in all cases the exception was generated.
According to the documentation, we're only supposed to call this before calling
stripe.confirmPayment, but we don't use that API, we process payments through intents in the backend. That makes me conclude we have an integration error because we're using different APIs, and the only solution is to remove that call, which has no effect.Testing instructions
Setup
npm run build:client.Regression test: Ensure ECE still works as expected
Test: Ensure ECE fails gracefully
Test: Ensure tokenized ECE works as expected
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge