-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Studio: Create new Previews tab and apply design changes #846
Studio: Create new Previews tab and apply design changes #846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, Kat!
I haven't finished the review yet, but noticed the following issue which I would like to share early:
When a new site is being created, it displays on the list as if it was already created:
Screen.Capture.on.2025-01-30.at.10-43-07.mov
It is likely related to the following behavior as well - where it looks like other local sites are generating preview sites as well (even when they are not):
Screen.Capture.on.2025-01-30.at.10-52-53.mp4
Thanks for pointing it out @ivan-ottinger - I have now addressed this in 7cbf41c where I noticed a small issue with filtering snapshots. Feel free to pull the most recent changes and let me know if you can still see the same problem. |
Nice! Thank you for fixing that. I cannot reproduce the issue anymore. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katinthehatsite works well now. 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this PR, Kat! I think it has moved the project forward a lot!
I haven't noticed any other functional issues. All the features are working well in my testing (creating, deleting, updating of preview sites; state when there are no preview sites, logged-out WPCOM user, no internet connection). Formatting of the RTL version is looking good as well.
I have shared a couple of ideas and thoughts in the inline comments below.
src/modules/preview-site/components/preview-links-table-header.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it and everything worked as expected.
Ivan made great suggestions, let's address them and merge the PR when ready.
We can create new issues for small tweaks in the UI.
…nt-design-for-quick-deploys
Related issues
Closes https://github.com/Automattic/dotcom-forge/issues/10277
Closes https://github.com/Automattic/dotcom-forge/issues/10354
Closes https://github.com/Automattic/dotcom-forge/issues/10356
Proposed Changes
This PR adds the design for the quick deploys according to Figma:
Before testing, please note the things that this PR DOES NOT do (there is already issues opened for these items):
Update
)Rename
currently does nothing)Testing Instructions
STUDIO_QUICK_DEPLOYS=true npm start
Previews
tabNotes
Pre-merge Checklist