Split sync:pull into 2 steps

[ashfame]

Related issues

• Fixes https://github.com/Automattic/dotcom-forge/issues/10036

Proposed Changes

In this PR, we change the sync:pull operation to check the backup size before download to prompt user if they really want to continue in case of site being too large to push back again.

"Cancel" halts the pull operation. "Continue" starts downloading the backup for restoration.

Also, added console log calls in a group:

Testing Instructions

• Restore a normal sized site (<2GB) and it would succeed exactly before the changes in this PR
• Modify SYNC_PUSH_SIZE_LIMIT_BYTES to be really small so that normal size backup is also over the max limit
• Try "pull" and you will see the prompt for Cancel/Continue

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[wojtekn]

The flow looks good, and works as expected.

We could change 'Pulling changes' message as now it makes less sense that it made before. I would propose 'Initializing backup' instead.

[wojtekn]

@ashfame I noticed one issue while testing. When I get a large backup dialog and I decide to cancel, I get the alert when I try to quit Studio:

[ashfame]

@wojtekn Regarding the message when you try to close the app, that's cool. I am seeing it for the first time. Looks like functioning as it should. Can you elaborate the issue?

[wojtekn]

@wojtekn Regarding the message when you try to close the app, that's cool. I am seeing it for the first time. Looks like functioning as it should. Can you elaborate the issue?

It should alert users when they try to close the app while the sync is running. In my case, the sync was not running, but I still got an alert:

1. Start a pull
2. See the large site notice
3. Click cancel (sync is not running anymore)
4. Close the Studio
5. Note that it displays the warning, but shouldn't

[ashfame]

Ah I see, missed "sync was not running" part. Thanks for explaining!

[ashfame]

@wojtekn Fixed the false "sync in progress" alarm. Ready for review again.

[wojtekn]

Thanks @ashfame - it doesn't show the dialog when I try to close the app now.

Could you please improve dialog message formatting and adjust the label mentioned in the comment above?

We could change 'Pulling changes' message as now it makes less sense that it made before. I would propose 'Initializing backup' instead.

[ashfame]

@wojtekn Sorry missed doing that, but done now.

[wojtekn]

Thanks @ashfame , they look consistent now:

Could you please change the label too?

We could change 'Pulling changes' message as now it makes less sense that it made before. I would propose 'Initializing backup' instead.

[ashfame]

@wojtekn Sorry, I am not sure what label are you referring to? Got clarification in DM

[katinthehatsite]

The changes look good 👍