-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split sync:pull into 2 steps #842
Conversation
check backup size before download in sync:pull to prompt user if they really want to continue in case of site being too large to push back again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flow looks good, and works as expected.
We could change 'Pulling changes' message as now it makes less sense that it made before. I would propose 'Initializing backup' instead.
@ashfame I noticed one issue while testing. When I get a large backup dialog and I decide to cancel, I get the alert when I try to quit Studio: ![]() |
Co-authored-by: Wojtek Naruniec <[email protected]>
Co-authored-by: Wojtek Naruniec <[email protected]>
Co-authored-by: Wojtek Naruniec <[email protected]>
@wojtekn Regarding the message when you try to close the app, that's cool. I am seeing it for the first time. Looks like functioning as it should. Can you elaborate the issue? |
It should alert users when they try to close the app while the sync is running. In my case, the sync was not running, but I still got an alert:
|
Ah I see, missed "sync was not running" part. Thanks for explaining! |
@wojtekn Fixed the false "sync in progress" alarm. Ready for review again. |
Thanks @ashfame - it doesn't show the dialog when I try to close the app now. Could you please improve dialog message formatting and adjust the label mentioned in the comment above?
|
@wojtekn Sorry missed doing that, but done now. |
Thanks @ashfame , they look consistent now: Could you please change the label too?
|
@wojtekn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good 👍
Related issues
Proposed Changes
In this PR, we change the sync:pull operation to check the backup size before download to prompt user if they really want to continue in case of site being too large to push back again.
"Cancel" halts the pull operation. "Continue" starts downloading the backup for restoration.
Also, added console log calls in a group:
Testing Instructions
SYNC_PUSH_SIZE_LIMIT_BYTES
to be really small so that normal size backup is also over the max limitPre-merge Checklist