Make unit tests pass on Windows #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekelund
changed the title
wojtekn
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Nice work @fredrikekelund !
Are we ready to enable (and rename) "Experiment Windows Unit Tests" to start running them on CI side again?
|
I didn't know we'd already configured a CI job for that. I've enabled it again as part of this PR 👍 (Fingers crossed it works now…) |
|
Looks like the CI process indeed works 🙂 |
|
Thanks @fredrikekelund ! 🥳 |
bgrgicak
pushed a commit
that referenced
this pull request
Jan 29, 2025
* WIP - Make unit tests pass on Windows * Fix DefaultExporter tests * Abstract the path mocking logic * Exclude tests/utils from Jest config * SqlExporter * PlaygroundValidator * Normalize paths passed to fs.__setFileContents * Fix file name * User data tests * Enable unit tests on Windows * Remove "Experiment" from name
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
This PR makes all unit tests pass on Windows by mocking the
pathmodule and/or using it correctly. Unsurprisingly, all of the failing tests were related to the differences between file paths on Unix and Windows…I've added
src/tests/utils/platform-test-suite.tsthat wraps a test suite in adescribe.eachcall that iterates over Unix and Windows platforms (meaning we run a mock test suite for both platforms at all times). Having this wrapper should make it easier to implement future tests for code that uses thepathmodule.Testing Instructions
Run
npm teston Windows and make sure all tests passPre-merge Checklist