Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support absolute import paths in Jest #832

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

fredrikekelund
Copy link
Contributor

Related issues

Proposed Changes

In #825, I added support for absolute imports starting with src/ or vendor/. Turns out we need to add this to Jest's config, too. This PR fixes that.

Testing Instructions

  1. Change one of the relative import paths in src/components/content-tab-assistant.tsx to be absolute
  2. Run npm run test src/components/tests/content-tab-assistant.test.tsx
  3. Ensure that the tests pass

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@fredrikekelund fredrikekelund requested a review from a team January 22, 2025 15:33
@fredrikekelund fredrikekelund self-assigned this Jan 22, 2025
Copy link
Contributor

@wojtekn wojtekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. The code change looks clear.

@fredrikekelund fredrikekelund merged commit 02ec1dd into trunk Jan 23, 2025
6 checks passed
@fredrikekelund fredrikekelund deleted the f26d/absolute-import-paths-jest branch January 23, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants