Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio: Fix spinner color when adding a site #367

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

katinthehatsite
Copy link
Contributor

After merging #362 , I noticed a small inconsistency in the design - the color of the spinner should be gray-70.

Before:
Screenshot 2024-07-18 at 9 32 41 AM

After:
Screenshot 2024-07-18 at 9 29 17 AM

Testing Instructions

  • Pull the changes from this branch
  • Start the app with nvm use && npm install && npm start
  • Click on the Add site button to open the modal
  • Click on Add site to add a site
  • Confirm that you see the loading indicator in the sidebar with the correct color

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@katinthehatsite katinthehatsite self-assigned this Jul 18, 2024
@katinthehatsite katinthehatsite requested a review from a team July 18, 2024 07:33
@matt-west
Copy link
Contributor

Thanks @katinthehatsite!

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

@katinthehatsite katinthehatsite merged commit 2de3ef9 into trunk Jul 18, 2024
10 checks passed
@katinthehatsite katinthehatsite deleted the fix/spinner-color branch July 18, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants