Improve validation of wp-cli commands that contain placeholder content
#309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2024
|
I merged the associated #305 but temporarily restored the branch. Running the following should allow rebasing the branch atop the latest trunk. git fetch && git rebase --onto origin/trunk origin/test/assert-assistant-code-block update/ai-improve-validation-wp-cli-commandConflicts may or may not need to be resolved during the rebase. |
dcalhoun
approved these changes
Jun 26, 2024
fluiddot
force-pushed
the
update/ai-improve-validation-wp-cli-command
branch
from
da8d171 to
dfc61cd
Compare
fluiddot
added a commit
that referenced
this pull request
Jun 27, 2024
…ent (#309) * Improve wp-cli command validation in AI responses * Fix placeholder calculation * Update `createCodeComponent` unit tests * Add `()` as potential wp-cli placeholder chars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #305 and #232 (comment).
Proposed Changes
wp-clicommand arguments inCodeBlockcomponent. This way we can detect placeholder characters more accurately.wp-clicommand as not eligible to be executed if any of its arguments start with a placeholder character.Testing Instructions
STUDIO_AI=true npm start.Show me how to get wordpress version via command.wp core version.Share a generic command to active a theme.wp theme activate {SLUG}(or similar placeholder format).Can you display the generic command with all possible combinations of placeholder characters? Each in a separate command..Pre-merge Checklist