fix: Reinstate Assistant a11y message groups #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This inclusion was presumably an oversight.
Pass ID to ensure the correct ARIA label is applied to the message group.
Without a unique ID, the message group is not appropriately labeled.
Group and label welcome messages to simplify navigation for users relying upon assistive technologies.
katinthehatsite
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #232 (review).
Proposed Changes
Reinstate ARIA labels for message groups. Update component types to avoid future
accidental removals. Expand message groups to include welcome messages.
Testing Instructions
See testing instructions in #248.
Pre-merge Checklist