Redesign titlebar: window title, button sizing, offline indicator#2675
Redesign titlebar: window title, button sizing, offline indicator#2675
Conversation
…n sizing
- Replace "Howdy, {user}" with Gravatar-only button (tooltip shows name)
- Add centered "Studio • {site name}" window title
- Add padding and rounded-lg to all titlebar icon buttons
- Increase sidebar toggle spacing from traffic lights
- Reduce top padding and right padding for better alignment
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The offline indicator isn't interactive — replace Button with a plain span[role=status] to remove misleading hover state while keeping the tooltip and accessibility attributes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📊 Performance Test ResultsComparing aec6ff8 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
|
@shaunandrews nice improvements! I merged the trunk into the branch and solved the conflict. Some notes:
|
katinthehatsite
left a comment
There was a problem hiding this comment.
Nice work, thanks for making these improvements!
I noticed two small things. The padding looks slightly too large when it is full size screen (I see it was also mentioned by another reviewer):
I also noticed that when a site has a very long name, it looks a bit weird but not sure if it is a big issue. We can also leave as is or crop it shorter as an alternative:
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Match gravatar button dimensions to other toolbar buttons and add a subtle border to tooltips for better contrast against dark backgrounds. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move bottom padding from TopBar (shared) to MacTitlebar (platform-specific) so Windows titlebar content centers naturally. Increase Windows titlebar from 32px to 44px to match other Electron apps. Make WindowTitle height platform-aware. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…title and WP logo Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
I fixed this in #2930, it was a regression introduced at some point. |
Tooltips don't have to be sentences, and should rarely be more than a few words. I think the button's label ("WordPress.com Log In") and the tooltip ("Enable Sync and Previews") together provide enough context to explain the connection between logging in and these gated features. FWIW I tried a few other options:
Its also possible that we don't need a tooltip here; the login button itself is already fairly unambiguous, but I thought it might be helpful to try and explain why you might click to login. |
|
@shaunandrews I think this tooltip starts to make sense as soon as we prepend it with "Log in to" to read "Log in to enable Sync and Previews," as you propose. Without "Log in to", the tooltip describes a side effect (sync and previews) rather than the primary action (logging in). |
With "Log in to" the tooltip is too long. If you feel strongly I'll remove it—I want to clean up some of these misaligned elements more than I want to add the tooltip—but with the surrounding context I think "Enable Sync and Previews" is good. |
# Conflicts: # apps/studio/src/components/top-bar.tsx
|
I guess we may have discrepancies with different plans now making the tooltip more complex. I'll just remove it for now. |
|
@shaunandrews Maybe in the end, we don't need a tooltip for that link? It's not an icon, and is already descriptive. |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
I removed the tooltip for the login button, and updated the branch. |






Before
After
Summary
p-1.5) androunded-lghover states. Sidebar toggle gets extra spacing from the traffic lights.pt-1.5from TopBar (chrome padding already handles it), reduced right padding so buttons sit closer to the window edge.Buttontospan[role=status]since it's not interactive. Removes misleading hover state while keeping tooltip and accessibility attributes. Addedfill-whitefor SVG visibility on dark chrome.bottom-endplacement so they don't overshoot the window edge.Test plan
npm test)🤖 Generated with Claude Code