Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio: Fix console errors on content-tab-assistant-test.tsx #251

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

katinthehatsite
Copy link
Contributor

@katinthehatsite katinthehatsite commented Jun 14, 2024

Related to #245

Proposed Changes

This PR fixes the console.error warnings for content-tab-assistant-test.tsx that were introduced when the PR mentioned above was merged:

Capture d’écran, le 2024-06-14 à 15 59 46

Although the tests are passing, the console throws errors. This happened because I introduced a new hook use-fetch-welcome-message that needed to be mocked in content-tab-assistant.

Testing Instructions

  • Pull the changes from this branch
  • Run npm run test
  • Observe that there are no warnings coming from content-tab-assistant-test.tsx and all the tests pass
  • Alternatively, you can check unit tests in Buildkite and confirm that there is no warnings once all the checks on this PR pass

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@katinthehatsite katinthehatsite self-assigned this Jun 14, 2024
@katinthehatsite katinthehatsite requested a review from a team June 14, 2024 14:03
Copy link
Contributor

@jeroenpf jeroenpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks pass and the error related to content-tab-assistant-test.tsx is no longer shown.

@katinthehatsite katinthehatsite merged commit dfb43ed into trunk Jun 14, 2024
12 checks passed
@katinthehatsite katinthehatsite deleted the fix/console-errors-on-content-tab-assistant branch June 14, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants