-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve AI assistant accessibility #248
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a2a2db0
feat: Hide decorative AI assistant icon from screen readers
dcalhoun 8d87b99
feat: Communicate message author to screen readers
dcalhoun 996b5f7
feat: Announce incoming assistant messages
dcalhoun 4e77ceb
fix: Assistant message labels exclude Markdown syntax
dcalhoun 36fdeb2
feat: Communicate the active assistant "thinking" to screen readers
dcalhoun 0ccfea7
Revert "feat: Announce incoming assistant messages"
dcalhoun 61daf0a
fix: Add ID to unauthenticated message
dcalhoun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,16 @@ | ||
import { ReactSVG, SVGProps } from 'react'; | ||
|
||
interface AssistantIconProps { | ||
size?: number; | ||
} | ||
|
||
export function AssistantIcon( { size = 14 }: AssistantIconProps ) { | ||
export function AssistantIcon( { | ||
size = 14, | ||
'aria-hidden': ariaHidden, | ||
}: AssistantIconProps & SVGProps< ReactSVG > ) { | ||
return ( | ||
<svg | ||
aria-hidden={ ariaHidden } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Previously, the existing |
||
width={ size } | ||
height={ size } | ||
viewBox={ `0 0 14 14` } | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrapping an element leveraging Tailwind's
sr-only
class is necessary to avoid unexpected overflow scrolling for the top level document.