Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock promptWindowsSpeedUpSites handler in onboarding unit tests #247

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jun 13, 2024

Related to #211 as it when the handler was introduced.

Proposed Changes

  • Mock promptWindowsSpeedUpSites IPC handled to avoid test failures.

Testing Instructions

  • Observe that all CI jobs succeed.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@fluiddot fluiddot requested review from a team June 13, 2024 15:44
@fluiddot fluiddot self-assigned this Jun 13, 2024
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I note we have one other error logged in the test results, but it appears unrelated to the target of the proposed changes.

Test log error
    console.warn
      PHP.run() output was: #!/usr/bin/env php


      at _NodePHP.run (node_modules/@php-wasm/node/index.cjs:72997:17)

    console.error
      PHPExecutionFailureError2: PHP.run() failed with exit code 1 and the following output:
          at _NodePHP.run (/Users/davidcalhoun/Sites/a8c/studio/node_modules/@php-wasm/node/index.cjs:72998:23) {
        response: _PHPResponse {
          httpStatusCode: 500,
          headers: { 'x-powered-by': [Array], 'content-type': [Array] },
          bytes: Uint8Array(19) [
             35,  33,  47, 117, 115, 114,
             47,  98, 105, 110,  47, 101,
            110, 118,  32, 112, 104, 112,
             10
          ],
          exitCode: 1,
          errors: ''
        },
        source: 'request'
      }

      at _NodePHP.run (node_modules/@php-wasm/node/index.cjs:73003:17)

@fluiddot
Copy link
Contributor Author

I note we have one other error logged in the test results, but it appears unrelated to the target of the proposed changes.

Yep, I checked the output of recent trunk commits, and seems the error log was introduced in #203. cc @katinthehatsite

@fluiddot fluiddot merged commit 617f9b6 into trunk Jun 13, 2024
12 checks passed
@fluiddot fluiddot deleted the fix/missing-function-in-onboarding-unit-test branch June 13, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants