fix: Improve button style consistency #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overloading the in-use `tertiary` button variant styles resulted in unexpected and inconsistent styles in the UI --- e.g., the "Add site" dialog. Introducing a new `outlined` variant achieves the original goal of a new button style that is now used in both the sidebar and AI assistant code blocks.
|
👋🏻 @matt-west. The changes I propose do not include the reduced button padding captured in the design proposal as I was uncertain if we intended to apply that to the "Add site" button as well. My thought is that the current padding used for all existing buttons looks fine for the inline code buttons (see images in the PR description). If you disagree, we could introduce additional one-off button style modifications for the padding of the inline code buttons. WDYT? |
3 tasks
|
Thanks for implementing this change @dcalhoun. I think the code buttons need the reduced padding, they're a bit too dominating at the moment. We should keep the existing padding for the |
The default button size is too large and dominating for the context of inline code within AI assistant responses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #214 (comment).
Proposed Changes
Introduce a new
outlinedbutton variant.Overloading the in-use
tertiarybutton variant styles resulted inunexpected and inconsistent styles in the UI --- e.g., the "Add site"
dialog. Introducing a new
outlinedvariant achieves the original goalof a new button style that is now used in both the sidebar and AI
assistant code blocks.
Testing Instructions
Expected outline button styles display
Expected tertiary button styles display
Pre-merge Checklist
Footnotes
The "Run" button is currently commented in the source code and thus hidden. ↩