Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix teacher email's label to say student's grade #7672

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

Imran92
Copy link
Contributor

@Imran92 Imran92 commented Aug 22, 2024

Proposed Changes

  • When a student completes a course, we send an email to the teacher. Now it says "Your grade" in it. I should be "Student's grade"

Testing Instructions

  • Go to Sensei LMS -> Tools -> Click on "Run Action" of the "Recreate Emails" tool
  • Go to Sensei LMS -> Settings -> Emails (tab) -> Teacher Emails (tab)
  • Open the "Course Completed" Email and make sure the grade label is "Student's Grade"
  • Now take a course as a student and complete it
  • Teacher's received email should have the new label

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Legacy courses (course without blocks) are tested
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@Imran92 Imran92 added this to the 4.24.4 milestone Aug 22, 2024
@Imran92 Imran92 requested a review from a team August 22, 2024 14:26
@Imran92 Imran92 self-assigned this Aug 22, 2024
Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link
Collaborator

@donnapep donnapep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it even simpler. 🙂

@donnapep donnapep merged commit ca19e19 into trunk Aug 23, 2024
23 checks passed
@donnapep donnapep deleted the fix/teacher-student-complete-email-label branch August 23, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants