Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix question description not being displayed #7669

Merged
merged 9 commits into from
Aug 20, 2024
Merged

Fix question description not being displayed #7669

merged 9 commits into from
Aug 20, 2024

Conversation

donnapep
Copy link
Collaborator

@donnapep donnapep commented Aug 16, 2024 •
edited
Loading

Resolves #7665.

Proposed Changes

Partially reverts the changes made in #7643 as it introduced a regression where question descriptions are not shown. Although I haven't confirmed, I'm suspicious that this change may have also introduced an issue where the View Certificate button is no longer displayed as per 8590896-zd-a8c. So I'm reverting that change as well.

Testing Instructions

  1. Create a quiz.
  2. Add descriptions to a question.
  3. Ensure the question description is displayed.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Legacy courses (course without blocks) are tested
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@donnapep donnapep added this to the 4.24.3 milestone Aug 16, 2024
@donnapep donnapep self-assigned this Aug 16, 2024
@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@donnapep donnapep requested review from merkushin and a team August 16, 2024 16:15
@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@donnapep donnapep changed the title Revert "Register blocks to make translations available in the editor" Fix question description not being displayed Aug 20, 2024
@donnapep donnapep mentioned this pull request Aug 20, 2024
Closed
@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

renatho
renatho approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@renatho renatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and the question description is displayed! 🎉

@donnapep donnapep merged commit 226c7ac into trunk Aug 20, 2024
23 checks passed
@donnapep donnapep deleted the revert/quiz-question-rendering branch August 20, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatho renatho renatho approved these changes

@merkushin merkushin Awaiting requested review from merkushin

Assignees

@donnapep donnapep

Labels
None yet
Projects
None yet
Milestone
4.24.3
Development

Successfully merging this pull request may close these issues.

Quiz description does not show up in 4.24.2
3 participants
@donnapep @merkushin @renatho