Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render Back to lesson when next_lesson_url has no value #7642

Merged
merged 5 commits into from
Jul 28, 2024
Merged

Render Back to lesson when next_lesson_url has no value #7642

merged 5 commits into from
Jul 28, 2024

Conversation

renintw
Copy link
Contributor

@renintw renintw commented Jul 24, 2024 •
edited by merkushin
Loading

Resolves WordPress/Learn#2687

Proposed Changes

When completing the quiz of the last lesson (example), it displays a 'Continue to next lesson' button which doesn't open anywhere.

Does it make sense to change to something like 'Back to lesson'?

Before After
image image

I noticed that the next_lesson_url is checked here so that it doesn't render the button on the bottom left when it doesn't have a value. The changes here refer to the logic there.

image

Testing Instructions

  1. Go to https://learn.wordpress.org/quiz/how-to-be-a-wordcamp-mentor-3/
  2. Complete the quiz.
  3. Click 'Continue to next lesson' button.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Legacy courses (course without blocks) are tested
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@renintw renintw self-assigned this Jul 24, 2024
@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@renintw
Copy link
Contributor Author

renintw commented Jul 24, 2024

Not sure who to ask for a review, so I clicked on the system's suggestion. Sorry if I asked the wrong person.

@renintw renintw requested a review from donnapep July 24, 2024 22:54
@merkushin merkushin self-requested a review July 26, 2024 17:04
@merkushin merkushin added this to the 4.24.2 milestone Jul 28, 2024
@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

merkushin
merkushin approved these changes Jul 28, 2024
View reviewed changes
Copy link
Member

@merkushin merkushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @renintw!

Looks good and works well.

I went ahead and updated the tests, and did some other minor adjustments to pass checks.

@merkushin merkushin merged commit eb1630b into trunk Jul 28, 2024
24 checks passed
@merkushin merkushin deleted the fix/continue-to-next-lesson-not-react branch July 28, 2024 19:21
@renintw
Copy link
Contributor Author

renintw commented Jul 29, 2024

Much appreciated for the help!

@renintw renintw mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merkushin merkushin merkushin approved these changes

@donnapep donnapep Awaiting requested review from donnapep

Assignees

@renintw renintw

Labels
None yet
Projects
None yet
Milestone
4.24.2
Development

Successfully merging this pull request may close these issues.

Feedback - Final Lesson has 'Continue to next lesson' Button that Doesn't Open
2 participants
@renintw @merkushin