Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix E2E tests #7641

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Fix E2E tests #7641

merged 4 commits into from
Jul 25, 2024

Conversation

m1r0
Copy link
Member

@m1r0 m1r0 commented Jul 24, 2024 •
edited
Loading

Closes #7618

Proposed Changes

  • Update the wp-env and playwright packages.
  • Fix the E2E tests not working.

Testing Instructions

The E2E tests CI job should be green.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Legacy courses (course without blocks) are tested
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@m1r0 m1r0 added this to the 4.24.2 milestone Jul 24, 2024
@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@m1r0 m1r0 marked this pull request as ready for review July 25, 2024 12:15
@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@github-actions GitHub Actions
Copy link

Test the previous changes of this PR with WordPress Playground.

@m1r0 m1r0 requested a review from a team July 25, 2024 12:26
renatho
renatho approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@renatho renatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you, Miro!

@m1r0 m1r0 merged commit a4a6647 into trunk Jul 25, 2024
23 checks passed
@m1r0 m1r0 deleted the fix/e2e-tests branch July 25, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatho renatho renatho approved these changes

Assignees
No one assigned
Labels
No Changelog
Projects
None yet
Milestone
4.24.2
Development

Successfully merging this pull request may close these issues.
2 participants
@m1r0 @renatho