Keep current status for a question when it is updated

changelog/fix-question-status-reset

@@ -0,0 +1,4 @@
+Significance: patch
+Type: fixed
+
+Keep current status for a question when it is updated

includes/rest-api/class-sensei-rest-api-question-helpers-trait.php

@@ -119,15 +119,15 @@ private function save_category_question( $question ) {
 			],
 		];
 
-		$result = wp_insert_post( $post_args );
+		$result = wp_update_post( $post_args );
 
 		/**
 		 * This action is triggered when a category question is created or updated by the lesson quiz REST endpoint.
 		 *
 		 * @since 3.9.0
 		 * @hook  sensei_rest_api_category_question_saved
 		 *
-		 * @param {int|WP_Error} $result   Result of wp_insert_post. Post ID on success or WP_Error on failure.
+		 * @param {int|WP_Error} $result   Result of wp_update_post. Post ID on success or WP_Error on failure.
 		 * @param {array}        $question The question JSON arguments.
 		 */
 		do_action( 'sensei_rest_api_category_question_saved', $result, $question );
@@ -196,7 +196,7 @@ private function save_question( $question, $status = 'publish' ) {
 			$post_args['post_content'] = $question['description'];
 		}
 
-		$result = wp_insert_post( $post_args );
+		$result = wp_update_post( $post_args );
 
 		if ( ! $is_new && ! is_wp_error( $result ) ) {
 			$this->migrate_non_editor_question( $result, $question['type'] );
@@ -208,7 +208,7 @@ private function save_question( $question, $status = 'publish' ) {
 		 * @since 3.9.0
 		 * @hook  sensei_rest_api_question_saved
 		 *
-		 * @param {int|WP_Error} $result        Result of wp_insert_post. Post ID on success or WP_Error on failure.
+		 * @param {int|WP_Error} $result        Result of wp_update_post. Post ID on success or WP_Error on failure.
 		 * @param {string}       $question_type The question type.
 		 * @param {array}        $question      The question JSON arguments.
 		 */
@@ -437,7 +437,7 @@ private function get_question( WP_Post $question ): array {
 	 *
 	 * @return array
 	 */
-	private function get_category_question( WP_Post $question ) : array {
+	private function get_category_question( WP_Post $question ): array {
 		$category = (int) get_post_meta( $question->ID, 'category', true );
 		$number   = (int) get_post_meta( $question->ID, 'number', true );
 
@@ -494,7 +494,7 @@ private function get_question_common_properties( WP_Post $question ): array {
 	 *
 	 * @return array Media info. It includes the type, id, url and title.
 	 */
-	private function get_question_media( int $question_media_id, int $question_id ) : array {
+	private function get_question_media( int $question_media_id, int $question_id ): array {
 		$question_media = [];
 		$mimetype       = get_post_mime_type( $question_media_id );
 		$attachment     = get_post( $question_media_id );

tests/unit-tests/rest-api/test-class-sensei-rest-api-questions-controller.php

@@ -357,6 +357,32 @@ public function testQuestionUpdateToDraft() {
 		$this->assertEquals( 'draft', get_post_status( $question_id ) );
 	}
 
+	public function testQuestionUpdate_WhenPublishedQuestionAndNoStatusInPayload_DoesnChangeStatusToDraft() {
+		/* Arrange. */
+		$this->login_as_admin();
+
+		$question_id = $this->factory->question->create();
+
+		$this->save_question_post(
+			$question_id,
+			[
+				'status'  => 'publish',
+				'content' => '<!-- wp:sensei-lms/quiz-question {"title":"Test"} --><!-- /wp:sensei-lms/quiz-question -->',
+			]
+		);
+
+		/* Act. */
+		$this->save_question_post(
+			$question_id,
+			[
+				'content' => '<!-- wp:sensei-lms/quiz-question {"title":"Test"} --><!-- /wp:sensei-lms/quiz-question -->',
+			]
+		);
+
+		/* Assert. */
+		$this->assertEquals( 'publish', get_post_status( $question_id ) );
+	}
+
 	public function testQuestionWithCategoryUpdateToDraft() {
 		$this->login_as_admin();