-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'Contact Teacher' and 'Conditional Content' block not appearing in site editor when Gutenberg enabled #7541
Fix 'Contact Teacher' and 'Conditional Content' block not appearing in site editor when Gutenberg enabled #7541
Conversation
WordPress Dependencies ReportThe
This comment was automatically generated by the |
Test the previous changes of this PR with WordPress Playground. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #7541 +/- ##
=========================================
Coverage 51.92% 51.92%
Complexity 11265 11265
=========================================
Files 630 630
Lines 47683 47683
Branches 421 421
=========================================
Hits 24759 24759
Misses 22587 22587
Partials 337 337 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Imran92!
It looks good and works well!
I just noticed another issue in the editor while testing it, but I confirmed that it's a Gutenberg issue and opened it here: WordPress/gutenberg#59917
@Imran92 I noticed in the screenshot from the ticket that the |
Thanks for noticing that @donnapep ! It only fixes the issue with these two blocks. After reading your comment, I did some more testing and found another issue. This happens only on WPCOM with Meraki theme when Gutenberg is activated. I've created and issue for it- |
Resolves issue of Contact Teacher button not appearing in site editor
Reported here 7876558-zd-a8c
Proposed Changes
Gutenberg recently added a change where it returns
wp_template
as current post ID in site editor instead of null whengetCurrentPostType
is called. So the checks that depended on this value being 'null' to detect if it's site editor, stopped working properly. This was a similar issue.Testing Instructions
Contact Teacher
block in the inserter, make sure it is therePre-Merge Checklist