Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update playground workflow to run only on pull requests #7527

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Mar 7, 2024

Proposed Changes

Testing Instructions

  1. Check that the Playground comment continues being added.
  2. And after merged, see that the workflow on trunk works properly.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Legacy courses (course without blocks) are tested
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@renatho renatho self-assigned this Mar 7, 2024
@renatho renatho added this to the 4.21.1 milestone Mar 7, 2024
@renatho renatho marked this pull request as ready for review March 7, 2024 14:25
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.79%. Comparing base (8281657) to head (3792c6a).
Report is 1 commits behind head on trunk.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              trunk    #7527   +/-   ##
=========================================
  Coverage     51.79%   51.79%           
  Complexity    11239    11239           
=========================================
  Files           622      622           
  Lines         47520    47520           
  Branches        414      414           
=========================================
  Hits          24613    24613           
  Misses        22574    22574           
  Partials        333      333           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4442766...3792c6a. Read the comment docs.

@renatho renatho force-pushed the fix/playground-workflow branch 5 times, most recently from fc07554 to 7e5bf38 Compare March 7, 2024 15:28
@renatho renatho marked this pull request as draft March 7, 2024 15:28
@renatho renatho force-pushed the fix/playground-workflow branch 4 times, most recently from 42f5696 to 5b4a71b Compare March 7, 2024 15:50
@Automattic Automattic deleted a comment from github-actions bot Mar 7, 2024
@renatho renatho force-pushed the fix/playground-workflow branch 5 times, most recently from 5b5d43e to ac01bde Compare March 7, 2024 16:16
@Automattic Automattic deleted a comment from github-actions bot Mar 7, 2024
@renatho renatho force-pushed the fix/playground-workflow branch 4 times, most recently from bab1b6f to 0690689 Compare March 7, 2024 16:48
@Automattic Automattic deleted a comment from github-actions bot Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

Test the previous changes of this PR with WordPress Playground.

@Automattic Automattic deleted a comment from github-actions bot Mar 7, 2024
@renatho renatho marked this pull request as ready for review March 7, 2024 17:00
@renatho renatho requested a review from a team March 7, 2024 17:00
@renatho renatho merged commit 10113b8 into trunk Mar 7, 2024
25 checks passed
@renatho renatho deleted the fix/playground-workflow branch March 7, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant