Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggested Folders] Update flow for free users #3573

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

mebarbosa
Copy link
Contributor

@mebarbosa mebarbosa commented Feb 10, 2025

Description

  • This PR displays the modal for free and logged-out users when opening the podcasts screen. Since we are not fetching the suggested folders from server yet, I am mocking 2 seconds of fetching and then display the modal.
  • I am ignoring if the user follows any podcasts for now, so they can see the modal even if does not follow a podcast. I will update this later
  • See: pdeCcb-8AH-p2

Fixes #3572

Testing Instructions

Free and Logged-Out Users

  1. Have the feature flag ON
  2. Go to Podcasts tab
  3. Wait for 2 seconds (mock)
  4. Ensure you see the Suggested Folder Paywall modal ✅
  5. Tap on Maybe Later Button
  6. Go to another screen
  7. Back to Podcasts tab again
  8. Ensure you don't see the Suggested Folder Paywall modal anymore ✅
  9. Tap to create a folder in folder toolbar icon
  10. Ensure you see the Suggested Folder Paywall modal ✅
  11. Repeat he test above with the feature flag OFF and ensure you don't see the modal

Paid Users

  1. Have the feature flag ON
  2. Log with a paid account
  3. Go to Podcasts tab
  4. Wait for 2 seconds (mock)
  5. Ensure you don't see the Suggested Folder Paywall modal ✅
  6. Tap to create a folder in folder toolbar icon
  7. Ensure you see the screen with suggested folders ✅

Screenshots or Screencast

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@mebarbosa mebarbosa added this to the 7.83 milestone Feb 10, 2025
@mebarbosa mebarbosa requested a review from a team as a code owner February 10, 2025 15:08
@mebarbosa mebarbosa requested review from geekygecko and removed request for a team February 10, 2025 15:08
@dangermattic
Copy link
Collaborator

dangermattic commented Feb 10, 2025

3 Warnings
⚠️ Class SuggestedFoldersPaywallViewModel is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ Class LongPref is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️ Class PrefFromLong is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 10, 2025

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commita0934fc
Direct Downloadpocketcasts-app-prototype-build-pr3573-a0934fc.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commita0934fc
Direct Downloadpocketcasts-automotive-prototype-build-pr3573-a0934fc.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commita0934fc
Direct Downloadpocketcasts-wear-prototype-build-pr3573-a0934fc.apk

@@ -555,6 +555,12 @@ class SettingsImpl @Inject constructor(
sharedPrefs = sharedPreferences,
)

override val suggestedFolderPaywallDismissTime = UserSetting.LongPref(
sharedPrefKey = "globalAutoDownloadNewEpisodes",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key for this doesn't look right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy and paste issue 🤦🏽‍♀️

It's fixed now a0934fc

Thanks for catching this!

@mebarbosa mebarbosa requested a review from geekygecko February 11, 2025 10:50
@mebarbosa mebarbosa merged commit 77ee0b4 into main Feb 11, 2025
16 checks passed
@mebarbosa mebarbosa deleted the task/update-suggested-folders-flow branch February 11, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggested Folders] Update flow for free users
4 participants