[Podcast Update Feed] Add Tooltip #3561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mebarbosa
added
[Type] Enhancement
mebarbosa
commented
Feb 6, 2025
Comment on lines
69
to
75
| <androidx.coordinatorlayout.widget.CoordinatorLayout | ||
| android:id="@+id/fullScreenDarkOverlayView" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:background="#80000000" | ||
| android:visibility="gone" /> | ||
|
|
There was a problem hiding this comment.
This was the only way I found to display the tooltip overlay in front of the bottom navigation view. Similar what we are doing for snackbarFragment
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
mebarbosa
commented
Feb 6, 2025
|
|
||
| private fun configureTooltip() { | ||
| lifecycleScope.launch { | ||
| delay(1.seconds) // Delay to wait the recyclerview to be configured |
There was a problem hiding this comment.
I added this delay because there is a race condition. Since we are aligning the tooltip with one recyclerview's item, I need to make sure this component has loaded. Using episodesRecyclerView?.doOnNextLayout was not enough
There was a problem hiding this comment.
I don't think this delay works if the page takes a while to load.
delay.mov
There was a problem hiding this comment.
It's fixed now. I had to mock low internet connection to be able to see this issue. See how it is now:
Screen_recording_20250207_123341.webm
geekygecko
approved these changes
Feb 7, 2025
...odcasts/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/view/podcast/PodcastTooltip.kt
Show resolved
Hide resolved
...odcasts/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/view/podcast/PodcastTooltip.kt
Outdated
Show resolved
Hide resolved
...odcasts/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/view/podcast/PodcastTooltip.kt
Outdated
Show resolved
Hide resolved
|
|
||
| private fun configureTooltip() { | ||
| lifecycleScope.launch { | ||
| delay(1.seconds) // Delay to wait the recyclerview to be configured |
There was a problem hiding this comment.
I don't think this delay works if the page takes a while to load.
delay.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Instructions
Feature flag disabled
Feature flag enabled
Screenshots or Screencast
Screen_recording_20250206_150940.webm
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...