Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces filtering out chapters that should not be in the table of contents. See the specification for more details.
The implementation relies on splitting real index and UI index. Real index is stored and is always used for syncing pre-selected chapters. While UI index is computed on-the-fly after we filter out all invalid chapters, etc.
In the database migration I had to delete all cached remote chapters as we don't have information whether such chapters should be displayed or not.
Fixes #3480
Testing Instructions
main
branch.X sats from Y
.task/chaptes-toc
branch.X sats from Y
chapters and no chapters got de-selected.Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)All strings that need to be localized are inmodules/services/localization/src/main/res/values/strings.xml
I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.