Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle claiming winback offer #3551

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Handle claiming winback offer #3551

merged 1 commit into from
Feb 6, 2025

Conversation

MiSikora
Copy link
Contributor

@MiSikora MiSikora commented Feb 5, 2025

Description

This PR adds claiming Winback offer Right now it is available only in staging due to Winback codes being available only there.

Testing Instructions

  1. Apply this winback.patch.
  2. Install the debugProd variant of the app.
  3. Sign in with an account without a subscription.
  4. If it is a new account wait for 3 minutes to make it old enough in the staging environment to make it eligible for the Winback offer.
  5. Subscribe to any plan.
  6. Go to the account details.
  7. Tap on "Cancel subscription".
  8. You should see a Winback offer.
  9. Tap on the Claim button.
  10. Play Store sheet should appear.
  11. Close the sheet without making a purchase.
  12. There should no loading dialog on top of UI.
  13. Claim the offer again.
  14. Finish the flow.
  15. You should see the confirmation screen.

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@MiSikora MiSikora added this to the 7.83 milestone Feb 5, 2025
@MiSikora MiSikora requested a review from a team as a code owner February 5, 2025 13:22
@MiSikora MiSikora requested review from mebarbosa and removed request for a team February 5, 2025 13:22
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 5, 2025

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commitae19d4d
Direct Downloadpocketcasts-app-prototype-build-pr3551-ae19d4d.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commitae19d4d
Direct Downloadpocketcasts-automotive-prototype-build-pr3551-ae19d4d.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commitae19d4d
Direct Downloadpocketcasts-wear-prototype-build-pr3551-ae19d4d.apk

Base automatically changed from task/winback-offer to main February 5, 2025 14:43
@mebarbosa
Copy link
Contributor

  1. Play Store sheet should appear.

I followed all steps, but I am not seeing this one. I am seeing the Enjoy your free month screen instead

@MiSikora
Copy link
Contributor Author

MiSikora commented Feb 6, 2025

I followed all steps, but I am not seeing this one. I am seeing the Enjoy your free month screen instead

I think you might be testing with a wrong branch.

Copy link
Contributor

@mebarbosa mebarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MiSikora MiSikora merged commit 9cc471c into main Feb 6, 2025
16 checks passed
@MiSikora MiSikora deleted the task/winback-claim branch February 6, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants