Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android 15 upgrade #3392

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Android 15 upgrade #3392

wants to merge 8 commits into from

Conversation

geekygecko
Copy link
Member

Description

Fixes #

Testing Instructions

Adding edge-to-edge support requires checking every page in the app. Areas of the app have been tested with pull request merges into task/android-15 but it would be good to smoke test the whole app. Here is the list that I went through:

  • Podcasts
    • Podcast Grid
    • Podcast
    • Share podcasts
  • Filters
  • Discover
  • Up Next
  • Profile

Screenshots or Screencast

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@dangermattic
Copy link
Collaborator

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 23, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit62bc5a4
Direct Downloadpocketcasts-app-prototype-build-pr3392-62bc5a4.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit62bc5a4
Direct Downloadpocketcasts-automotive-prototype-build-pr3392-62bc5a4.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit62bc5a4
Direct Downloadpocketcasts-wear-prototype-build-pr3392-62bc5a4.apk

@wpmobilebot
Copy link
Collaborator

Project dependencies changes

The following changes in project dependencies were detected (configuration releaseRuntimeClasspath):

list
Upgraded Dependencies
androidx.transition:transition:1.5.0, (changed from 1.4.1)
com.google.android.material:material:1.12.0, (changed from 1.11.0)
tree
 +--- com.automattic:encryptedlogging:0.0.1
 |    \--- org.wordpress:utils:3.14.0
-|         \--- com.google.android.material:material:1.2.1 -> 1.11.0
-|              +--- org.jetbrains.kotlin:kotlin-bom:1.8.22
-|              |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.1.0 (c)
-|              |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.8.22 -> 2.1.0 (c)
-|              |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.22 -> 2.1.0 (c)
-|              |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.22 -> 2.1.0 (c)
-|              +--- com.google.errorprone:error_prone_annotations:2.15.0 -> 2.28.0
-|              +--- androidx.activity:activity:1.8.0 -> 1.9.3 (*)
-|              +--- androidx.annotation:annotation:1.2.0 -> 1.9.1 (*)
-|              +--- androidx.appcompat:appcompat:1.6.1 -> 1.7.0 (*)
-|              +--- androidx.cardview:cardview:1.0.0
-|              |    \--- androidx.annotation:annotation:1.0.0 -> 1.9.1 (*)
-|              +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0
-|              |    +--- androidx.annotation:annotation:1.1.0 -> 1.9.1 (*)
-|              |    +--- androidx.core:core:1.1.0 -> 1.13.1 (*)
-|              |    +--- androidx.customview:customview:1.0.0 -> 1.1.0 (*)
-|              |    \--- androidx.collection:collection:1.0.0 -> 1.4.4 (*)
-|              +--- androidx.constraintlayout:constraintlayout:2.0.1 -> 2.1.4
-|              |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.7.0 (*)
-|              |    +--- androidx.core:core:1.3.2 -> 1.13.1 (*)
-|              |    \--- androidx.constraintlayout:constraintlayout-core:1.0.4
-|              +--- androidx.core:core:1.6.0 -> 1.13.1 (*)
-|              +--- androidx.drawerlayout:drawerlayout:1.1.1 (*)
-|              +--- androidx.dynamicanimation:dynamicanimation:1.0.0
-|              |    +--- androidx.core:core:1.0.0 -> 1.13.1 (*)
-|              |    +--- androidx.collection:collection:1.0.0 -> 1.4.4 (*)
-|              |    \--- androidx.legacy:legacy-support-core-utils:1.0.0 (*)
-|              +--- androidx.annotation:annotation-experimental:1.0.0 -> 1.4.1 (*)
-|              +--- androidx.fragment:fragment:1.2.5 -> 1.8.5 (*)
-|              +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.8.7 (*)
-|              +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
-|              +--- androidx.resourceinspection:resourceinspection-annotation:1.0.1 (*)
-|              +--- androidx.transition:transition:1.2.0 -> 1.4.1
-|              |    +--- androidx.annotation:annotation:1.1.0 -> 1.9.1 (*)
-|              |    +--- androidx.core:core:1.1.0 -> 1.13.1 (*)
-|              |    \--- androidx.collection:collection:1.1.0 -> 1.4.4 (*)
-|              +--- androidx.vectordrawable:vectordrawable:1.1.0 (*)
-|              \--- androidx.viewpager2:viewpager2:1.0.0 -> 1.1.0
-|                   +--- androidx.annotation:annotation:1.1.0 -> 1.9.1 (*)
-|                   +--- androidx.annotation:annotation-experimental:1.4.0 -> 1.4.1 (*)
-|                   +--- androidx.collection:collection:1.1.0 -> 1.4.4 (*)
-|                   +--- androidx.core:core:1.3.2 -> 1.13.1 (*)
-|                   +--- androidx.fragment:fragment:1.1.0 -> 1.8.5 (*)
-|                   \--- androidx.recyclerview:recyclerview:1.3.1 -> 1.3.2 (*)
+|         \--- com.google.android.material:material:1.2.1 -> 1.12.0
+|              +--- org.jetbrains.kotlin:kotlin-bom:1.8.22
+|              |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.1.0 (c)
+|              |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.22 -> 2.1.0 (c)
+|              |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.8.22 -> 2.1.0 (c)
+|              |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.22 -> 2.1.0 (c)
+|              +--- com.google.errorprone:error_prone_annotations:2.15.0 -> 2.28.0
+|              +--- androidx.activity:activity:1.8.0 -> 1.9.3 (*)
+|              +--- androidx.annotation:annotation:1.2.0 -> 1.9.1 (*)
+|              +--- androidx.appcompat:appcompat:1.6.1 -> 1.7.0 (*)
+|              +--- androidx.cardview:cardview:1.0.0
+|              |    \--- androidx.annotation:annotation:1.0.0 -> 1.9.1 (*)
+|              +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0
+|              |    +--- androidx.annotation:annotation:1.1.0 -> 1.9.1 (*)
+|              |    +--- androidx.core:core:1.1.0 -> 1.13.1 (*)
+|              |    +--- androidx.customview:customview:1.0.0 -> 1.1.0 (*)
+|              |    \--- androidx.collection:collection:1.0.0 -> 1.4.4 (*)
+|              +--- androidx.constraintlayout:constraintlayout:2.0.1 -> 2.1.4
+|              |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.7.0 (*)
+|              |    +--- androidx.core:core:1.3.2 -> 1.13.1 (*)
+|              |    \--- androidx.constraintlayout:constraintlayout-core:1.0.4
+|              +--- androidx.core:core:1.6.0 -> 1.13.1 (*)
+|              +--- androidx.drawerlayout:drawerlayout:1.1.1 (*)
+|              +--- androidx.dynamicanimation:dynamicanimation:1.0.0
+|              |    +--- androidx.core:core:1.0.0 -> 1.13.1 (*)
+|              |    +--- androidx.collection:collection:1.0.0 -> 1.4.4 (*)
+|              |    \--- androidx.legacy:legacy-support-core-utils:1.0.0 (*)
+|              +--- androidx.annotation:annotation-experimental:1.0.0 -> 1.4.1 (*)
+|              +--- androidx.fragment:fragment:1.2.5 -> 1.8.5 (*)
+|              +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.8.7 (*)
+|              +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
+|              +--- androidx.resourceinspection:resourceinspection-annotation:1.0.1 (*)
+|              +--- androidx.transition:transition:1.5.0
+|              |    +--- androidx.annotation:annotation:1.2.0 -> 1.9.1 (*)
+|              |    +--- androidx.collection:collection:1.1.0 -> 1.4.4 (*)
+|              |    +--- androidx.core:core:1.13.0 -> 1.13.1 (*)
+|              |    \--- androidx.dynamicanimation:dynamicanimation:1.0.0 (*)
+|              +--- androidx.vectordrawable:vectordrawable:1.1.0 (*)
+|              \--- androidx.viewpager2:viewpager2:1.0.0 -> 1.1.0
+|                   +--- androidx.annotation:annotation:1.1.0 -> 1.9.1 (*)
+|                   +--- androidx.annotation:annotation-experimental:1.4.0 -> 1.4.1 (*)
+|                   +--- androidx.collection:collection:1.1.0 -> 1.4.4 (*)
+|                   +--- androidx.core:core:1.3.2 -> 1.13.1 (*)
+|                   +--- androidx.fragment:fragment:1.1.0 -> 1.8.5 (*)
+|                   \--- androidx.recyclerview:recyclerview:1.3.1 -> 1.3.2 (*)
-+--- com.google.android.material:material:1.9.0 -> 1.11.0 (*)
++--- com.google.android.material:material:1.12.0 (*)
 +--- project :modules:features:account
-|    +--- com.google.android.material:material:1.9.0 -> 1.11.0 (*)
+|    +--- com.google.android.material:material:1.12.0 (*)
 |    +--- project :modules:features:search
 |    |    +--- project :modules:services:analytics
 |    |    |    +--- project :modules:services:model
 |    |    |    |    \--- project :modules:services:utils
-|    |    |    |         \--- com.google.android.material:material:1.9.0 -> 1.11.0 (*)
+|    |    |    |         \--- com.google.android.material:material:1.12.0 (*)
 |    |    |    \--- project :modules:services:preferences
 |    |    |         +--- androidx.preference:preference-ktx:1.2.1
 |    |    |         |    \--- androidx.preference:preference:1.2.1
 |    |    |         |         \--- androidx.slidingpanelayout:slidingpanelayout:1.2.0
-|    |    |         |              \--- androidx.transition:transition:1.4.1 (*)
+|    |    |         |              \--- androidx.transition:transition:1.4.1 -> 1.5.0 (*)
 |    |    |         \--- project :modules:services:images
-|    |    |              \--- com.google.android.material:material:1.9.0 -> 1.11.0 (*)
+|    |    |              \--- com.google.android.material:material:1.12.0 (*)
 |    |    +--- project :modules:services:repositories
-|    |    |    \--- com.google.android.material:material:1.9.0 -> 1.11.0 (*)
+|    |    |    \--- com.google.android.material:material:1.12.0 (*)
 |    |    +--- project :modules:services:ui
-|    |    |    \--- com.google.android.material:material:1.9.0 -> 1.11.0 (*)
+|    |    |    \--- com.google.android.material:material:1.12.0 (*)
 |    |    \--- project :modules:services:views
-|    |         +--- com.google.android.material:material:1.9.0 -> 1.11.0 (*)
+|    |         +--- com.google.android.material:material:1.12.0 (*)
-|    |         \--- androidx.fragment:fragment-compose:1.8.5
-|    |              +--- androidx.compose.runtime:runtime:1.5.4 -> 1.7.4 (*)
-|    |              +--- androidx.compose.ui:ui:1.5.4 -> 1.7.4 (*)
-|    |              +--- androidx.core:core-ktx:1.12.0 -> 1.13.1 (*)
-|    |              +--- androidx.fragment:fragment-ktx:1.8.5 (*)
-|    |              +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.1.0 (*)
-|    |              +--- androidx.fragment:fragment:1.8.5 (c)
-|    |              \--- androidx.fragment:fragment-ktx:1.8.5 (c)
+|    |         +--- project :modules:services:compose
+|    |         |    \--- androidx.fragment:fragment-compose:1.8.5
+|    |         |         +--- androidx.compose.runtime:runtime:1.5.4 -> 1.7.4 (*)
+|    |         |         +--- androidx.compose.ui:ui:1.5.4 -> 1.7.4 (*)
+|    |         |         +--- androidx.core:core-ktx:1.12.0 -> 1.13.1 (*)
+|    |         |         +--- androidx.fragment:fragment-ktx:1.8.5 (*)
+|    |         |         +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.1.0 (*)
+|    |         |         +--- androidx.fragment:fragment:1.8.5 (c)
+|    |         |         \--- androidx.fragment:fragment-ktx:1.8.5 (c)
+|    |         \--- androidx.fragment:fragment-compose:1.8.5 (*)
 |    +--- project :modules:features:settings
-|    |    \--- com.google.android.material:material:1.9.0 -> 1.11.0 (*)
+|    |    \--- com.google.android.material:material:1.12.0 (*)
 |    +--- androidx.navigation:navigation-ui-ktx:2.7.7
 |    |    \--- androidx.navigation:navigation-ui:2.7.7
-|    |         +--- androidx.transition:transition:1.3.0 -> 1.4.1 (*)
+|    |         +--- androidx.transition:transition:1.3.0 -> 1.5.0 (*)
-|    |         \--- com.google.android.material:material:1.4.0-beta01 -> 1.11.0 (*)
+|    |         \--- com.google.android.material:material:1.4.0-beta01 -> 1.12.0 (*)
 |    \--- project :modules:features:cartheme
-|         \--- com.google.android.material:material:1.9.0 -> 1.11.0 (*)
+|         \--- com.google.android.material:material:1.12.0 (*)
 +--- project :modules:features:discover
-|    +--- com.google.android.material:material:1.9.0 -> 1.11.0 (*)
+|    +--- com.google.android.material:material:1.12.0 (*)
 |    \--- project :modules:features:podcasts
-|         +--- com.google.android.material:material:1.9.0 -> 1.11.0 (*)
+|         +--- com.google.android.material:material:1.12.0 (*)
 |         \--- project :modules:features:player
-|              +--- com.google.android.material:material:1.9.0 -> 1.11.0 (*)
+|              +--- com.google.android.material:material:1.12.0 (*)
 |              \--- io.github.kevinnzou:compose-webview:0.33.6
-|                   \--- com.google.android.material:material:1.11.0 (*)
+|                   \--- com.google.android.material:material:1.11.0 -> 1.12.0 (*)
 +--- project :modules:features:filters
-|    \--- com.google.android.material:material:1.9.0 -> 1.11.0 (*)
+|    \--- com.google.android.material:material:1.12.0 (*)
 +--- project :modules:features:navigation
-|    \--- com.google.android.material:material:1.9.0 -> 1.11.0 (*)
+|    \--- com.google.android.material:material:1.12.0 (*)
 \--- project :modules:features:profile
-     \--- com.google.android.material:material:1.9.0 -> 1.11.0 (*)
+     \--- com.google.android.material:material:1.12.0 (*)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants