Skip to content

Commit

Permalink
Tracks Audit: Add more eventos for Filters (#3425)
Browse files Browse the repository at this point in the history
  • Loading branch information
mebarbosa authored Jan 13, 2025
1 parent 0bfd777 commit d58fd47
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ class FiltersFragment : BaseFragment(), CoroutineScope, Toolbar.OnMenuItemClickL
override fun onMenuItemClick(item: MenuItem): Boolean {
return when (item.itemId) {
R.id.filter_create -> {
viewModel.trackOnCreateFilterTap()
openCreate()
true
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,4 +88,8 @@ class FiltersFragmentViewModel @Inject constructor(
onSuccess(playlist)
}
}

fun trackOnCreateFilterTap() {
analyticsTracker.track(AnalyticsEvent.FILTER_CREATE_BUTTON_TAPPED)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ import android.view.View
import android.view.ViewGroup
import androidx.core.view.isVisible
import androidx.fragment.app.commit
import au.com.shiftyjelly.pocketcasts.analytics.AnalyticsEvent
import au.com.shiftyjelly.pocketcasts.analytics.AnalyticsTracker
import au.com.shiftyjelly.pocketcasts.analytics.SourceView
import au.com.shiftyjelly.pocketcasts.filters.databinding.PodcastOptionsFragmentBinding
import au.com.shiftyjelly.pocketcasts.models.entity.Playlist
import au.com.shiftyjelly.pocketcasts.repositories.podcast.PlaylistManager
Expand Down Expand Up @@ -54,6 +57,8 @@ class PodcastOptionsFragment : BaseFragment(), PodcastSelectFragment.Listener, C

@Inject lateinit var playlistManager: PlaylistManager

@Inject lateinit var analyticsTracker: AnalyticsTracker

var podcastSelection: List<String> = listOf()
var playlist: Playlist? = null
private var binding: PodcastOptionsFragmentBinding? = null
Expand Down Expand Up @@ -99,6 +104,7 @@ class PodcastOptionsFragment : BaseFragment(), PodcastSelectFragment.Listener, C
}

switchAllPodcasts.setOnCheckedChangeListener { _, isChecked ->
analyticsTracker.track(AnalyticsEvent.SETTINGS_SELECT_PODCASTS_SELECT_ALL_PODCASTS_TOGGLED, mapOf("source" to SourceView.FILTERS.analyticsValue, "enabled" to isChecked))
podcastSelectDisabled.isVisible = isChecked
if (!isChecked) {
podcastSelection = emptyList()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,7 @@ enum class AnalyticsEvent(val key: String) {
/* Filters */
FILTER_AUTO_DOWNLOAD_LIMIT_UPDATED("filter_auto_download_limit_updated"),
FILTER_AUTO_DOWNLOAD_UPDATED("filter_auto_download_updated"),
FILTER_CREATE_BUTTON_TAPPED("filter_create_button_tapped"),
FILTER_CREATED("filter_created"),
FILTER_DELETED("filter_deleted"),
FILTER_EDIT_DISMISSED("filter_edit_dismissed"),
Expand Down Expand Up @@ -520,6 +521,7 @@ enum class AnalyticsEvent(val key: String) {
SETTINGS_SELECT_PODCASTS_SELECT_ALL_TAPPED("settings_select_podcasts_select_all_tapped"),
SETTINGS_SELECT_PODCASTS_SELECT_NONE_TAPPED("settings_select_podcasts_select_none_tapped"),
SETTINGS_SELECT_PODCASTS_PODCAST_TOGGLED("settings_select_podcasts_podcast_toggled"),
SETTINGS_SELECT_PODCASTS_SELECT_ALL_PODCASTS_TOGGLED("settings_select_podcasts_select_all_podcasts_toggled"),

/* Settings - Files */
SETTINGS_FILES_SHOWN("settings_files_shown"),
Expand Down

0 comments on commit d58fd47

Please sign in to comment.