Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore method used by migration scripts #2741

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix: restore method used by migration scripts #2741

merged 1 commit into from
Nov 6, 2023

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Nov 6, 2023 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Restores a method that was accidentally removed in #2663. This method is needed for migration scripts.

How to test the changes in this Pull Request:

Confirm that the method is restored exactly as it was when it was first added. You can test with WP shell:

> $customer = new WC_Customer( 42 ) // ID for a WC customer account
> Newspack\WooCommerce_Connection::get_contact_from_customer( $customer )
= [
    "email" => "[email protected]",
    "name" => "Test Donor",
    "metadata" => [
      "NP_Account" => 42,
      "NP_Registration Date" => "2023-11-03",
    ],
  ]

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added the [Status] Needs Review The issue or pull request needs to be reviewed label Nov 6, 2023
@dkoo dkoo self-assigned this Nov 6, 2023
@dkoo dkoo requested a review from a team as a code owner November 6, 2023 23:09
claudiulodro
claudiulodro approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@claudiulodro claudiulodro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well and looks exactly the same as before. Thanks for adding this back!

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Nov 6, 2023
@dkoo dkoo merged commit d8d0860 into release Nov 6, 2023
2 checks passed
@dkoo dkoo deleted the hotfix/restore-missing-method branch November 6, 2023 23:39
matticbot pushed a commit that referenced this pull request Nov 6, 2023
@semantic-release-bot
chore(release): 2.10.2 [skip ci]
27296dd 
## [2.10.2](v2.10.1...v2.10.2) (2023-11-06)

### Bug Fixes

* restore method used by migration scripts ([#2741](#2741)) ([d8d0860](d8d0860))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.10.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Nov 6, 2023
@semantic-release-bot
chore(release): 2.11.0-alpha.5 [skip ci]
43ea0cf 
# [2.11.0-alpha.5](v2.11.0-alpha.4...v2.11.0-alpha.5) (2023-11-06)

### Bug Fixes

* restore method used by migration scripts ([#2741](#2741)) ([d8d0860](d8d0860))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.11.0-alpha.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiulodro claudiulodro claudiulodro approved these changes

Assignees

@dkoo dkoo

Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkoo @matticbot @claudiulodro