Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth-modal): handle very long newsletter lists list #2732

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Handle very long lists of newsletter lists.

See 1200133283036252-as-1205829529414334

How to test the changes in this Pull Request:

  1. On master, go to Engagement -> Newsletters -> Subscription Lists and edit a list description to something super long. Can be your favourite book, for example.
  2. Visit the site, click on the "My Account" in top-right corner, then "I don't have an account"
  3. Observe the lists are making the modal assume the window height, with the CTAs pushed below the fold
  4. Switch to this branch, observe the newsletters lists list is scrollable

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Nov 3, 2023
@adekbadek adekbadek requested a review from a team as a code owner November 3, 2023 15:25
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Nov 7, 2023
@adekbadek adekbadek merged commit ad6895e into master Nov 8, 2023
2 checks passed
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.11.1-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.11.2-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.11.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants