Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(media-credit): refactor clauses for credit search #2691

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix(media-credit): refactor clauses for credit search #2691

merged 1 commit into from
Oct 10, 2023

Conversation

miguelpeixe
Copy link
Member

@miguelpeixe miguelpeixe commented Oct 10, 2023 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Refactors the media credit search feature to use custom query clauses in order to avoid conflicting with other plugins that may add other joins to the query.

How to test the changes in this Pull Request:

  1. Add credit metadata to an attachment
  2. Make sure you have Jetpack's VideoPress active
  3. Visit the Media Library and search using the credit value
  4. Confirm the search returns the attachment
  5. Written tests should continue to pass

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe self-assigned this Oct 10, 2023
@miguelpeixe miguelpeixe marked this pull request as ready for review October 10, 2023 14:13
@miguelpeixe miguelpeixe requested a review from a team as a code owner October 10, 2023 14:13
@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Oct 10, 2023
@miguelpeixe miguelpeixe mentioned this pull request Oct 10, 2023
Closed
6 tasks
dkoo
dkoo approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Oct 10, 2023
@miguelpeixe miguelpeixe merged commit 6547fe1 into release Oct 10, 2023
@miguelpeixe miguelpeixe deleted the hotfix/media-credit-search-clauses branch October 10, 2023 15:48
matticbot pushed a commit that referenced this pull request Oct 10, 2023
@semantic-release-bot
chore(release): 2.8.1 [skip ci]
769b794 
## [2.8.1](v2.8.0...v2.8.1) (2023-10-10)

### Bug Fixes

* **media-credit:** refactor clauses for credit search ([#2691](#2691)) ([6547fe1](6547fe1))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@miguelpeixe miguelpeixe mentioned this pull request Oct 10, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

Assignees

@miguelpeixe miguelpeixe

Labels
released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelpeixe @matticbot @dkoo