Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Perfmatters to managed plugins #2684

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Conversation

gamebits
Copy link
Contributor

@gamebits gamebits commented Oct 6, 2023

Adds Perfmatters to our list of managed plugins.

All Submissions:

Changes proposed in this Pull Request:

Adds Perfmatters to our list of managed plugins.

Also deletes Perfmatters, Super Cool Ad Inserter Plugin, and Ads.txt Manager from our list of "supported, but not managed" plugins, since they are in fact managed (SCAIP as of #246 and Ads.txt Manager as of #2639).

How to test the changes in this Pull Request:

  1. Switch to this branch.
  2. Ensure the Newspack plugin is active.
  3. Visit /wp-admin/plugins.php
  4. Verify that Perfmatters, whether or not it's installed, is nested under "Newspack" and prefixed with a hyphen.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Adds Perfmatters to our list of managed plugins. Also deletes Perfmatters, SCAIP, and Ads.txt Manager from our list of "supported, but not managed" plugins, since they are in fact managed (SCAIP as of #246 and Ads.txt Manager as of #2639).
@gamebits gamebits requested a review from a team as a code owner October 6, 2023 19:47
@github-actions github-actions bot added the [Status] Approved The pull request has been reviewed and is ready to merge label Oct 9, 2023
@adekbadek adekbadek merged commit eb657d8 into master Oct 9, 2023
1 check passed
@adekbadek adekbadek deleted the feat/perfmatters-managed branch October 9, 2023 09:28
matticbot pushed a commit that referenced this pull request Oct 16, 2023
# [2.9.0-alpha.1](v2.8.3...v2.9.0-alpha.1) (2023-10-16)

### Features

* add Perfmatters to managed plugins ([#2684](#2684)) ([eb657d8](eb657d8))
* **design-wizard:** allow bulk update of featured image, post template ([#2670](#2670)) ([37a4656](37a4656))
* newspack_managed_plugins filter ([#2605](#2605)) ([81ba5f2](81ba5f2))
* **reader-registration:** custom checkbox state for lists ([#2682](#2682)) ([b8ce865](b8ce865))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.9.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Oct 17, 2023
# [2.10.0-alpha.1](v2.9.0...v2.10.0-alpha.1) (2023-10-17)

### Features

* add Perfmatters to managed plugins ([#2684](#2684)) ([eb657d8](eb657d8))
* **design-wizard:** allow bulk update of featured image, post template ([#2670](#2670)) ([37a4656](37a4656))
* newspack_managed_plugins filter ([#2605](#2605)) ([81ba5f2](81ba5f2))
* **reader-registration:** custom checkbox state for lists ([#2682](#2682)) ([b8ce865](b8ce865))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.10.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Oct 31, 2023
# [2.10.0](v2.9.1...v2.10.0) (2023-10-31)

### Features

* add Perfmatters to managed plugins ([#2684](#2684)) ([eb657d8](eb657d8))
* **data-events:** activecampaign connector ([#2663](#2663)) ([377a51f](377a51f))
* **design-wizard:** allow bulk update of featured image, post template ([#2670](#2670)) ([37a4656](37a4656))
* newspack_managed_plugins filter ([#2605](#2605)) ([81ba5f2](81ba5f2))
* **ras:** custom newsletter list selection on registration ([#2706](#2706)) ([57b2871](57b2871))
* **ras:** overlay management for content gate refresh ([#2708](#2708)) ([6767740](6767740))
* **reader-registration:** custom checkbox state for lists ([#2682](#2682)) ([b8ce865](b8ce865))
* remove order-received text ([#2707](#2707)) ([a386524](a386524))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants