Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ras-acc): revert RAS-ACC release #1721

Closed
wants to merge 2 commits into from
Closed

fix(ras-acc): revert RAS-ACC release #1721

wants to merge 2 commits into from

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Dec 9, 2024

This reverts commit 39a94e9a5fd33dfa9e2e04315985b3e339ed7f73, reversing changes made to 1acd7cdce479453e0596cee74d59f27883fc96a1.

All Submissions:

Changes proposed in this Pull Request:

This is a "just in case" PR, to be used only if we need to revert the RAS-ACC release in #1720.

How to test the changes in this Pull Request:

  1. Confirm that the changeset is identical to (but opposite of) that from Release Dec 09 #1720.
  2. Confirm that the plugin runs and is functionally identical to v3.5.0.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo self-assigned this Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 39.02439% with 25 lines in your changes missing coverage. Please review.

Project coverage is 23.00%. Comparing base (ad092ca) to head (2792c28).
Report is 7 commits behind head on release.

Files with missing lines Patch % Lines
...ass-newspack-newsletters-mailchimp-cached-data.php 29.41% 24 Missing ⚠️
...rs/class-newspack-newsletters-service-provider.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             release    #1721      +/-   ##
=============================================
- Coverage      23.07%   23.00%   -0.08%     
+ Complexity      2713     2710       -3     
=============================================
  Files             49       49              
  Lines          10761    10751      -10     
=============================================
- Hits            2483     2473      -10     
  Misses          8278     8278              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the [Status] Approved Ready to merge label Dec 9, 2024
@dkoo
Copy link
Contributor Author

dkoo commented Jan 7, 2025

Looks like we won't need this!

@dkoo dkoo closed this Jan 7, 2025
@dkoo dkoo deleted the revert/ras-acc branch January 7, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Approved Ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants