ci: Use artifacts, not cache, for intra-workflow communication #46911
+71
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've started to see random failures in the E2E and WP Cloud test runs, which seem to be due to GitHub not being able to fetch the cache entry despite it having just been created. Their support AI bot insists that actions/cache isn't intended to be used for use between jobs in the same workflow. Seems bogus to me, but regardless we can get better reliability by using artifact upload/download rather than the cache. Since I'm poking it anyway, let's do some extra cleanup too: * For the WP Cloud job, we can do `jetpack rsync` to a local directory and put that in the artifact instead of shoving the build of everything in there. * Looks like the WP Cloud site is on PHP 8.3 now, so bump that version. * For the E2E, I think actions/cache had been deduplicating duplicate files, while tar won't by itself. But we can get tar to do it by hard-linking the files.
anomiex
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes MONOREP-340
Proposed changes:
We've started to see random failures in the E2E and WP Cloud test runs, which seem to be due to GitHub not being able to fetch the cache entry despite it having just been created.
Their support AI bot insists that actions/cache isn't intended to be used for use between jobs in the same workflow. Seems bogus to me, but regardless we can get better reliability by using artifact upload/download rather than the cache.
Since I'm poking it anyway, let's do some extra cleanup too:
jetpack rsyncto a local directory and put that in the artifact instead of shoving the build of everything in there.Other information:
Jetpack product discussion
p1769703130539749-slack-C05Q5HSS013
Does this pull request change what data or activity we track or use?
No
Testing instructions: