Skip to content

My Jetpack: Prevent red bubble fatals when notification data is malformed #45385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
+7 −0
Open

My Jetpack: Prevent red bubble fatals when notification data is malformed #45385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2ed1a3
Prevent fatals when handling unexpected data
tbradsha Oct 6, 2025
15127cb
Add changelog
tbradsha Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/my-jetpack/changelog/fix-my-jetpack-red_bubble_fatals
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Prevent PHP errors when notification data is malformed.
3 changes: 3 additions & 0 deletions projects/packages/my-jetpack/src/class-red-bubble-notifications.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ public static function register_rest_endpoints() {
'type' => 'string',
),
'sanitize_callback' => function ( $param ) {
if ( ! is_array( $param ) ) {
return array();
}
return array_map( 'sanitize_text_field', $param );
},
),
Expand Down
Loading