-
Notifications
You must be signed in to change notification settings - Fork 835
WIP: Forms: Optimize count queries with single optimized endpoint #45377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 🔴 Action required: Please include detailed testing steps, explaining how to test your change, like so:
🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:
Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Code Coverage SummaryCannot generate coverage summary while tests are failing. 🤐 Please fix the tests, or re-run the Code coverage job if it was something being flaky. |
3c87d4d
to
d6ea2bf
Compare
Reduces from 3 separate REST requests to 1 optimized database query with caching. Related: #45339
51096e2
to
454ddbf
Compare
closing in favor of #45427 |
DON'T TEST yet, it breaks the filter, I am working on it (@lezama )
Summary
Replaces 3 separate REST API requests for status counts (inbox/spam/trash) with a single optimized database query.
Changes
/wp/v2/feedback/counts
REST endpoint with optimized single-query count logicuse-inbox-data
to use new endpoint instead of 3useEntityRecords
callsPerformance Impact
Related
Main PR: #45339