-
Notifications
You must be signed in to change notification settings - Fork 875
Forms: Add response view actions #45352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
5029ac0
add basic actions on response view
CGastrell f2e5726
add actions on all statuses, tweak styles for action buttons
CGastrell e58f5dd
changelog
CGastrell 158a489
move styles to file
CGastrell 3c0b931
add icons for read/unread and navigation buttons. Apply design
CGastrell 6b13053
fix selection/sidepanel flow
CGastrell 573aa8d
unselect the actioned item, retain previous selection
CGastrell b03557a
fix sidepanel so selected response stays in view
CGastrell 75ef840
limit sidepanel height to match the list container's
CGastrell d0d7584
fine tune the envelope icons
CGastrell 1eb0017
Update the icons to be normal size.
enejb e02cf5e
update the read icons to match figma
enejb a17dd7f
update all buttons to be seconday
enejb ec994e0
Update style.scss
enejb fc41492
Use icons and labels from actions
simison fea7937
Remove unread/read button for now
simison 79423ff
Add busy state to actions
simison c2fe22c
Show tooltip for disabled next/prev buttons
simison fda0188
Fix header spacing to be equal up/down
simison 2b15ab9
Fix Gravatar from shrinking
simison 1a11445
Use more components and rely less on custom CSS
simison ba4c3f3
Fix mobile styling
simison 313a7b3
Update modal copy
simison File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
projects/packages/forms/changelog/add-forms-response-view-actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: minor | ||
| Type: added | ||
|
|
||
| Forms: add actions on dashboard inbox's single response view |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,4 @@ | ||
| export { default as notSpam } from './not-spam'; | ||
| export { default as spam } from './spam'; | ||
| export { default as read } from './read'; | ||
| export { default as unread } from './unread'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| /** | ||
| * External dependencies | ||
| */ | ||
| import { Path, SVG } from '@wordpress/primitives'; | ||
|
|
||
| const read = ( | ||
| <SVG xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="none"> | ||
| <Path | ||
| fill-rule="evenodd" | ||
| d="M3 7c0-1.10457.89543-2 2-2h14c1.1046 0 2 .89543 2 2v10c0 1.1046-.8954 2-2 2H5c-1.10457 0-2-.8954-2-2V7Zm2-.5h14c.2761 0 .5.22386.5.5v.93754L12 13.5625 4.5 7.93746V7c0-.27614.22386-.5.5-.5Zm-.5 3.31246V17c0 .2761.22386.5.5.5h14c.2761 0 .5-.2239.5-.5V9.81254L12 15.4375 4.5 9.81246Z" | ||
| clip-rule="evenodd" | ||
| /> | ||
| </SVG> | ||
| ); | ||
|
|
||
| export default read; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| /** | ||
| * External dependencies | ||
| */ | ||
| import { Path, SVG } from '@wordpress/primitives'; | ||
|
|
||
| const unread = ( | ||
| <SVG xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="none"> | ||
| <Path d="M20.991 9.263c0-.644-.333-1.208-.846-1.52L12 3 3.855 7.742A1.78 1.78 0 0 0 3 9.263v8.947A1.8 1.8 0 0 0 4.8 20h14.4a1.8 1.8 0 0 0 1.8-1.79l-.009-8.947Zm-1.8 0v.01L12 13.736 4.8 9.263 12 5.076l7.191 4.187ZM4.8 18.21v-6.853l7.2 4.491 7.191-4.464.009 6.826H4.8Z" /> | ||
| </SVG> | ||
| ); | ||
|
|
||
| export default unread; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use
@wordpress/iconsinstead of shipping our own SVGs.