Forms: add read/unread state to the UI #45350

enejb · 2025-10-02T04:44:41Z

Adds new feedback/read endpoint and the new UI that lets you mark feedback as read and unread.

This new state is shown as a dot. this is due to the current limitation of the data views which prevent the whole row from being bold.

Proposed changes:

Adds a new endpoints for marking feedback responses from being read or unread.
Add UI changes so that you see unread feedback responses as read.
Add the ability to mark responses as read or unread.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

See FORMS-302

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Add a form and fill it out.
Notice that this response will show up as unread in the forms UI.
Notice that you mark previous responses as read and unread.

github-actions · 2025-10-02T04:45:31Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/forms-unread-state branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/forms-unread-state

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-10-02T04:45:41Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2025-10-02T04:53:53Z

Code Coverage Summary

Coverage changed in 9 files. Only the first 5 are listed here.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/dashboard/inbox/dataviews/actions.js	0/122 (0.00%)	0.00%	36 💔
projects/packages/forms/src/dashboard/inbox/response.js	0/140 (0.00%)	0.00%	19 💔
projects/packages/forms/src/dashboard/inbox/utils.js	0/13 (0.00%)	0.00%	8 💔
projects/packages/forms/src/dashboard/inbox/dataviews/index.js	0/156 (0.00%)	0.00%	6 💔
projects/packages/forms/src/contact-form/class-contact-form-endpoint.php	630/708 (88.98%)	0.18%	5 💔

Full summary · PHP report · JS report

_{If appropriate, add one of these labels to override the failing coverage check:

Covered by non-unit tests
Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code

Coverage tests to be added later
Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.}

edanzer

This tests fairly well and is an exciting change to see.

The good:

Once this PR is loaded, any new form responses show as unread (with red dot).
Interacting with unread messages updates status to read (no more dot)
Selecting items in bulk and clicking the "Mark unread" button successfully marks them unread (with red dot).
Using the actions dropdown for a single response to mark an item read or unread works.
Tests pass

Potential improvements:

The dot in my testing is small and red. I like the bigger, blue one in the PR description a bit more :). It is a shame we can't otherwise style the un-read item rows more (ie, bolding or background color).
Could be done in a follow up, but now that feedback objects have an unread property, I wonder if we could use that to determine the number we show in the notifications bubble in the admin menu for Jetpack and Forms. As is, these are totally unconnected.
- Example: Say I have 5 unread messages and I see that button Jetpack and Forms. Soon as I click the inbox, that gets cleared even though I still have unread messages. Also marking message read or unread also doesn't affect that.
There's a small TS error that needs resolving.

enejb · 2025-10-02T21:39:49Z

Thanks for the review @edanzer!

should we should the red bubble.

Yes we should. This part needs updating. ( I think we should switch to a new option ) and go and update the total unread, Everytime we add a new response and when we switch the read state. Ideally this value would also change as we update the count live on the page.

I updated design to be indicate that the Response is unread by making the different elements bold.
It looks like this now. cc @ilonagl.

CGastrell

Works great!

simison · 2025-10-07T06:44:23Z

projects/packages/forms/src/contact-form/class-contact-form-plugin.php

+	 */
+	public static function recalculate_unread_count() {
+		$count = Feedback::get_unread_count();
+		update_option( 'feedback_unread_count_v2', $count );


We could use jetpack_ prefix since we're renaming anyway. 🤔

Is there some pre-loading also happening with jetpack_ prefixed options, some different helper functions, and perhaps they get synced automatically?

ilonagl · 2025-10-07T14:00:49Z

Could we make the dot the same color (#d63638) as the notification bubble, so it's easier to connect the dots (no pun intended haha)?

ilonagl · 2025-10-07T14:08:28Z

Other than that, it works great!

…hem as read once they are viewed

Replaces legacy unread feedback count logic with new static methods in Contact_Form_Plugin and Feedback classes, storing the count in a new option. Updates backend to recalculate and return the unread count after marking feedback as read/unread. Frontend now updates the admin menu counter dynamically using the new count from the server, improving accuracy and consistency.

simison · 2025-10-08T13:57:49Z

projects/packages/forms/src/dashboard/inbox/response.js

 			default: // 'publish' (inbox) or any other status
 				return (
 					<>
+						{ response.is_unread && (


Should these actions be available to all, inbox/spam/trash views? 🤔

simison

Testing overall well; tested also combined counts with and without unread form responses:

In a follow-up, let's iterate on +/-:ing sidebar counter optimistically (#45398) instead of having a delay or have counter not work when starting form zero.

Let's also refresh counts when unread posts are moved as-is to trash, or marked as spam. I don't think we should have those in the counter, only inbox-unreads. In this example count is 3, but one unread is in trash:

edanzer

Just retested following latest changes. Everything that was working before is working now but now with other nice improvements.

I like the bolding for unread items!
Great to see the syncing between unread items and the notification bubble on the Jetpack/Forms dashboard menu.
Single response action buttons to mark unread are working great.

Improvements:

The only small issue I'm seeing is that there can be a delay between when I read an item / mark an item unread and when I see the number in the menu notification bubble change. I assume that's some delay due to need to round trip an endpoint request to update the notification count. Probably something we should improve, but it could easily be handled in a follow up.
UPDATE: Can also confirm from other findings, that if you mark an unread item as spam or trash, the number on the dashboard menu doesn't change. Didn't notice this initially because normally I'd read an item before marking it spam or trashing it.
Still some failing tests / static analysis issues

simison · 2025-10-08T18:47:00Z

The only small issue I'm seeing is that there can be a delay between when I read an item / mark an item unread and when I see the number in the menu notification bubble change.

Yep, started on improving it here:

Forms: optimistically update count in sidebar for read/unread actions #45398

enejb added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Package] Forms labels Oct 2, 2025

enejb changed the title ~~Add/forms unread state~~ Forms: add read/unread state to the UI Oct 2, 2025

github-actions bot added [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests labels Oct 2, 2025

edanzer reviewed Oct 2, 2025

View reviewed changes

simison force-pushed the add/forms-unread-state branch from bd305b5 to 1e06088 Compare October 4, 2025 12:31

CGastrell previously approved these changes Oct 4, 2025

View reviewed changes

CGastrell mentioned this pull request Oct 5, 2025

Forms: Add response view actions #45352

Merged

3 tasks

enejb dismissed CGastrell’s stale review via 38fbc5c October 6, 2025 04:10

simison reviewed Oct 7, 2025

View reviewed changes

simison force-pushed the add/forms-unread-state branch from 38fbc5c to a841fbc Compare October 7, 2025 07:04

This was referenced Oct 7, 2025

Forms: optimistically update count in sidebar for read/unread actions #45397

Closed

Forms: optimistically update count in sidebar for read/unread actions #45398

Closed

enejb and others added 8 commits October 8, 2025 05:41

Update the feedback class to have is_unread property

5956aa5

Add new endpoint that lets us marks things as read and unread

0adfba1

Update the UI that lets us shows us things that are unread and mark t…

4ab077c

…hem as read once they are viewed

Add DataView actions

a65d79a

changelog

af57b78

Update the style

1ef26d2

Make things bold

4d1adbc

Swap icons and add back indicator dot

ac76925

enejb and others added 6 commits October 8, 2025 05:43

Clarify JS comments

a13b8a2

Move menu updated to utils

9573b8e

Always output counter badge

6f48d7a

Make the dot red.

58464df

Add mark as read buttons

ea73e41

enejb force-pushed the add/forms-unread-state branch from bdccb87 to ea73e41 Compare October 8, 2025 13:37

Update the option name

7da12f0

simison reviewed Oct 8, 2025

View reviewed changes

simison previously approved these changes Oct 8, 2025

View reviewed changes

edanzer reviewed Oct 8, 2025

View reviewed changes

Update the tests to remove untestable code

3e0f19c

enejb dismissed simison’s stale review via 3e0f19c October 8, 2025 17:11

enejb added 5 commits October 8, 2025 10:15

Add read unread buttons to each inbox header

0ea3469

Fix typescript error

78aba78

fix phan

04fc9a1

More tests.

e5cf202

More tests...

c100ffe

enejb merged commit 97a59da into trunk Oct 8, 2025
66 of 67 checks passed

enejb deleted the add/forms-unread-state branch October 8, 2025 20:17

github-actions bot added this to the jetpack/15.2 milestone Oct 8, 2025

github-actions bot removed the [Status] Needs Review This PR is ready for review. label Oct 8, 2025

This was referenced Oct 8, 2025

Forms: optimistically update count in sidebar for read/unread actions (take two) #45425

Open

Forms: fix missing tooltip on unread/read quick action button #45433

Merged

enejb mentioned this pull request Oct 9, 2025

Forms: Fix feedback is unread endpoint #45439

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Forms: add read/unread state to the UI #45350

Forms: add read/unread state to the UI #45350

enejb commented Oct 2, 2025

Uh oh!

github-actions bot commented Oct 2, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 2, 2025 •

edited

Loading

Uh oh!

jp-launch-control bot commented Oct 2, 2025 •

edited

Loading

Uh oh!

edanzer left a comment •

edited

Loading

Uh oh!

enejb commented Oct 2, 2025

Uh oh!

CGastrell left a comment

Uh oh!

simison Oct 7, 2025

Uh oh!

enejb Oct 7, 2025

Uh oh!

simison Oct 7, 2025

Uh oh!

ilonagl commented Oct 7, 2025 •

edited

Loading

Uh oh!

ilonagl commented Oct 7, 2025

Uh oh!

simison Oct 8, 2025

Uh oh!

simison left a comment •

edited

Loading

Uh oh!

edanzer left a comment •

edited

Loading

Uh oh!

simison commented Oct 8, 2025

Uh oh!

Uh oh!

Uh oh!

Forms: add read/unread state to the UI #45350

Forms: add read/unread state to the UI #45350

Conversation

enejb commented Oct 2, 2025

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

edanzer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

enejb commented Oct 2, 2025

Uh oh!

CGastrell left a comment

Choose a reason for hiding this comment

Uh oh!

simison Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

enejb Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

simison Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

ilonagl commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ilonagl commented Oct 7, 2025

Uh oh!

simison Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

simison left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

edanzer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

simison commented Oct 8, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 2, 2025 •

edited

Loading

github-actions bot commented Oct 2, 2025 •

edited

Loading

jp-launch-control bot commented Oct 2, 2025 •

edited

Loading

edanzer left a comment •

edited

Loading

ilonagl commented Oct 7, 2025 •

edited

Loading

simison left a comment •

edited

Loading

edanzer left a comment •

edited

Loading