Sharing service: Prevent various undefined array key warnings

[coder-karen]

Fixes VULCAN-137

Proposed changes:

• This PR prevents a few undefined array key warnings: Warning: Undefined array key "sharing_label", Undefined array key "custom", Undefined array key "hidden", Undefined array key "visible", as well as a rarer fatal - Uncaught Error: Call to a member function get_name() on false
• The approach to fix these is just to check if they are set
• In the case of the fatal, we check to see if $this->service an instance of Sharing_Source, as it can be an bool.
• Logs: c9a04af81a4f4f4eec9167d272bcbe2f-logstash

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pdWQjU-1g0-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

I've been unable to replicate the warnings in practice, but it would seem they are likely happening when options are corrupted or not fully initialized. In most cases the warnings can be replicated by modifiying the relevant options values. So, a good way to test this is with a sandboxed Jurassic Ninja site. I recommend using a JN site because we're modifying options (so if you are using the JN site for anything else you may want to note the options when retrieveing them, and reset them back to original values afterwards):

• Create a Jurassic Ninja site using the ?specialops=true options - make sure to select 'Enable Sandbox access' (you don't need the Jetpack Beta tester plugin).
• Visit Settings > Jetpack Constants, and add your sandbox domain
• Connect Jetpack
• Retrieve your new blog ID from the Jetpack debugger
• Open up your sandbox, and in wpsh run the following:

switch_to_blog(YOUR_BLOG_ID);
return get_option('sharing-options');
$options['global'] = array()
update_option('sharing-options', $options);

• Then visit the Jetpack Stats page (Jetpack > Stats).
• Make sure you are tailing errors - tail -f /tmp/php-errors - and you should see undefined array key warnings related to the custom and sharing_label keys.
• Then, run the following:

return get_option('sharing-services');
$services = array();
update_option('sharing-services', $services);

• Then visit the Jetpack Stats page again (Jetpack > Stats).
• You should see undefined array key warnings related to the visible and hidden keys now.

The only other change is the check to see if $this->service is an instance of Sharing_Source - this has only occurred twice over the last month, and proof-reading the change should be sufficient.

• That said the warning can be replicated (Uncaught Error: Call to a member function get_name() on false) by directly setting $this->service to false here, before we set $this->name.
• You'd be best making the change via moon or sun in your sandbox (whichever is active for testing).
• Then sandbox a Simple test site and visit the following page: /wp-admin/admin.php?page=stats. You should see the warning on trunk
• With the PR applied using the command in the generated comment below, and with $this->service still set to false, the warning should not exist.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/sharing-service-undefined-array-key branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/sharing-service-undefined-array-key

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly:
  • Scheduled release: June 3, 2025
  • Code freeze: June 2, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[jp-launch-control]

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/jetpack/modules/sharedaddy/sharing-service.php	185/467 (39.61%)	0.04%	1 ❤️‍🩹

Full summary · PHP report · JS report

[jeherve]

Would it work to be more specific, and check for the Sharing_Source instead, so we know get_name will be in there?

[coder-karen]

Yes, good point. I was also able to come up with steps to replicate the warning and test the fix now for this specific change too (although it looks straightforward to check if it's an instance of Sharing_Source, I wanted to be sure there wouldn't be additional errors) , so updated the testing instructions.